vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-06-28 22:30:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix js-cookie types (#42483)

Browse Source 
* Update js-cookie types

Calls to set return a string or undefined, not void, as seen here:
https://github.com/js-cookie/js-cookie/blob/master/src/api.mjs#L7
https://github.com/js-cookie/js-cookie/blob/master/src/api.mjs#L47

* Update js-cookie tests
This commit is contained in:
Tom B
2020-02-25 19:40:03 -05:00
committed by GitHub
parent 4872b8c4d6
commit 71f3a59bbb
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
types/js-cookie/index.d.ts vendored
View File

@@ -57,7 +57,7 @@ declare namespace Cookies {
/**
* Create a cookie
*/
set(name: string, value: string | T, options?: CookieAttributes): void;
set(name: string, value: string | T, options?: CookieAttributes): string | undefined;
/**
* Read cookie

1
types/js-cookie/js-cookie-tests.ts
View File

@@ -1,5 +1,6 @@
import Cookies = require("js-cookie");
// $ExpectType string | undefined
Cookies.set('name', 'value');
Cookies.set('name', 'value', { expires: 7 });
Cookies.set('name', 'value', { expires: new Date() });