vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-06-28 22:30:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #25972 from shetzel/master

Browse Source 
[@types/jsforce] fixes Connection.query signature to accept the optio…
This commit is contained in:
Daniel Rosenwasser
2018-05-27 00:59:54 -07:00
committed by GitHub
parent 4e13a44994 70b686c494
commit 771c5ccd17
3 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
types/jsforce/connection.d.ts vendored
View File

@@ -1,6 +1,6 @@
import { EventEmitter } from 'events';
import { DescribeSObjectResult, DescribeGlobalResult } from './describe-result';
import { Query, QueryResult } from './query';
import { Query, QueryResult, ExecuteOptions } from './query';
import { Record } from './record';
import { RecordResult } from './record-result';
import { SObject } from './salesforce-object';
@@ -93,8 +93,8 @@ export type ConnectionEvent = "refresh";
export abstract class BaseConnection extends EventEmitter {
_baseUrl(): string;
request(info: RequestInfo | string, options?: Object, callback?: (err: Error, Object: object) => void): Promise<Object>;
query<T>(soql: string, callback?: (err: Error, result: QueryResult<T>) => void): Query<QueryResult<T>>;
queryMore<T>(locator: string, options?: object, callback?: (err: Error, result: QueryResult<T>) => void): Promise<QueryResult<T>>;
query<T>(soql: string, options?: ExecuteOptions, callback?: (err: Error, result: QueryResult<T>) => void): Query<QueryResult<T>>;
queryMore<T>(locator: string, options?: ExecuteOptions, callback?: (err: Error, result: QueryResult<T>) => void): Promise<QueryResult<T>>;
create<T>(type: string, records: Record<T> | Array<Record<T>>, options?: Object,
callback?: (err: Error, result: RecordResult | RecordResult[]) => void): Promise<(RecordResult | RecordResult[])>;
insert<T>(type: string, records: Record<T> | Array<Record<T>>, options?: Object,

8
types/jsforce/jsforce-tests.ts
View File

@@ -30,6 +30,14 @@ const requestInfo: sf.RequestInfo = {
};
salesforceConnection.request(requestInfo);
const queryOptions: sf.ExecuteOptions = {
autoFetch: true,
maxFetch: 5000,
headers: {},
scanAll: true
};
salesforceConnection.query('SELECT Id, Name FROM Account', queryOptions);
// note the following should never compile:
// salesforceConnection.sobject<DummyRecord>("Dummy").select(["lol"]);

3
types/jsforce/query.d.ts vendored
View File

@@ -5,7 +5,8 @@ import { RecordResult } from './record-result';
export interface ExecuteOptions {
autoFetch?: boolean;
maxFetch?: number;
scanAll?: number;
headers?: object;
scanAll?: boolean;
}
export interface QueryResult<T> {