Merge pull request #34304 from unindented/master

Update type definitions for react-helmet-async v1.0

types/react-helmet-async/index.d.ts

@@ -1,13 +1,14 @@
-// Type definitions for react-helmet-async 0.0
-// Project: https://github.com/staylor/react-helmet-async#readme, https://github.com/nytimes/react-helmet-async
+// Type definitions for react-helmet-async 1.0
+// Project: https://github.com/staylor/react-helmet-async, https://github.com/nytimes/react-helmet-async
 // Definitions by: forabi <https://github.com/forabi>
+//                 Daniel Perez Alvarez <https://github.com/unindented>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
 // TypeScript Version: 2.8
 
-import * as React from 'react';
+import * as React from "react";
+import { HelmetData } from "react-helmet";
 
-import Helmet, { HelmetData } from 'react-helmet';
-export default Helmet;
+export { default as Helmet } from "react-helmet";
 
 export interface PopulatedContext {
     helmet: HelmetData;

types/react-helmet-async/react-helmet-async-tests.tsx

@@ -1,15 +1,38 @@
-import * as React from 'react';
-import { renderToString } from 'react-dom/server';
-import Helmet, { HelmetProvider, PopulatedContext } from 'react-helmet-async';
+import * as React from "react";
+import * as ReactDOM from "react-dom";
+import { renderToString } from "react-dom/server";
+import { Helmet, HelmetProvider, PopulatedContext } from "react-helmet-async";
 
-const helmetContext = {};
-
-const markup = renderToString(
-    <HelmetProvider context={helmetContext}>
+const App1 = () => (
+    <HelmetProvider>
         <div>
             <Helmet>
-                <title>Hello, world!</title>
+                <title>Hello World</title>
+                <link rel="canonical" href="https://www.example.com/" />
             </Helmet>
+            <h1>Hello World</h1>
         </div>
     </HelmetProvider>
 );
+
+ReactDOM.render(<App1 />, document.getElementById("root"));
+
+const helmetContext = {};
+
+const App2 = () => (
+    <HelmetProvider context={helmetContext}>
+        <div>
+            <Helmet>
+                <title>Hello World</title>
+                <link rel="canonical" href="https://www.tacobell.com/" />
+            </Helmet>
+            <h1>Hello World</h1>
+        </div>
+    </HelmetProvider>
+);
+
+const html = renderToString(<App2 />);
+console.log(html);
+
+const { helmet } = helmetContext as PopulatedContext;
+console.log(helmet);

types/react-helmet-async/tsconfig.json

@@ -1,7 +1,7 @@
 {
     "compilerOptions": {
         "module": "commonjs",
-        "lib": ["es6"],
+        "lib": ["dom", "es6"],
         "noImplicitAny": true,
         "noImplicitThis": true,
         "strictNullChecks": true,