vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-08-11 20:40:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

allow numbers as the right hand side of a join equality (#14823)

Browse Source
This commit is contained in:
Chet Husk
2017-03-10 15:17:36 -08:00
committed by Mohamed Hegazy
parent 75ffb8e47d
commit a43da75444
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
knex/index.d.ts
Vendored
+1 -1
View File
@@ -165,7 +165,7 @@ declare namespace Knex {
interface Join {
(raw: Raw): QueryBuilder;
(tableName: string, columns: { [key: string]: string | Raw }): QueryBuilder;
(tableName: string, columns: { [key: string]: string | number | Raw }): QueryBuilder;
(tableName: string, callback: Function): QueryBuilder;
(tableName: TableName, raw: Raw): QueryBuilder;
(tableName: TableName, column1: string, column2: string): QueryBuilder;
knex/knex-tests.ts
+4
View File
@@ -188,6 +188,10 @@ knex('users')
.join('contacts', 'users.id', '=', 'contacts.user_id')
.select('users.id', 'contacts.phone');
knex('users')
.join('contacts', { 'users.id': 12355 })
.select('users.id', 'contacts.phone');
knex('users')
.join('contacts', 'users.id', 'contacts.user_id')
.select('users.id', 'contacts.phone');