Merge pull request #21301 from segayuu/acorn-cleanup-ignore-lint-errors

[acorn] Cleanup ignore lint errors

types/acorn/acorn-tests.ts

@@ -1,13 +1,13 @@
 import acorn = require('acorn');
 import * as ESTree from 'estree';
 
-declare var token: acorn.Token;
-declare var tokens: acorn.Token[];
-declare var comment: acorn.Comment;
-declare var comments: acorn.Comment[];
-declare var program: ESTree.Program;
-var any: any;
-var string: string;
+declare let token: acorn.Token;
+declare let tokens: acorn.Token[];
+declare let comment: acorn.Comment;
+declare let comments: acorn.Comment[];
+declare let program: ESTree.Program;
+let any: any;
+let string: string;
 
 // acorn
 string = acorn.version;
@@ -32,16 +32,12 @@ const parser = new acorn.Parser({}, 'export default ""', 0);
 const node = new acorn.Node(parser, 1, 1);
 
 class LooseParser {
-    constructor(input: string, options = {}) {
-
-    }
+    constructor(input: string, options = {}) {}
 
     // this means you can extend LooseParser
-    test() {
-
-    }
+    test() {}
 }
-acorn.addLooseExports(function () {
+acorn.addLooseExports(() => {
     return {
         type: 'Program',
         sourceType: 'script',
@@ -50,7 +46,7 @@ acorn.addLooseExports(function () {
                 type: 'EmptyStatement'
             }
         ]
-    }
+    };
 }, LooseParser, {});
 
 acorn.parseExpressionAt('string', 2);
@@ -63,8 +59,7 @@ acorn.isIdentifierChar(56);
 
 acorn.getLineInfo('string', 56);
 
-acorn.plugins['test'] = function (p: acorn.Parser, config: any) {
-}
+acorn.plugins['test'] = (p: acorn.Parser, config: any) => {};
 
 acorn.tokenizer('console.log("hello world)', {locations: true}).getToken();
 acorn.tokenizer('console.log("hello world)', {locations: true})[Symbol.iterator]().next();

types/acorn/index.d.ts

@@ -1,10 +1,8 @@
-// Type definitions for Acorn v4.0.3
+// Type definitions for Acorn 4.0
 // Project: https://github.com/marijnh/acorn
 // Definitions by: RReverser <https://github.com/RReverser>, e-cloud <https://github.com/e-cloud>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
 
-/// <reference types="estree" />
-
 export as namespace acorn;
 export = acorn;
 import * as ESTree from 'estree';
@@ -181,7 +179,7 @@ declare namespace acorn {
         _typeof: TokenType;
         _void: TokenType;
         _delete: TokenType;
-    }
+    };
 
     class TokContext {
         constructor(token: string, isExpr: boolean, preserveSpace: boolean, override: (p: Parser) => void);
@@ -230,19 +228,18 @@ declare namespace acorn {
 
     const version: string;
 
-    interface IParse {
-        (input: string, options?: Options): ESTree.Program;
-    }
+    // TODO: rename type.
+    type IParse = (input: string, options?: Options) => ESTree.Program;
 
     const parse: IParse;
 
     function parseExpressionAt(input: string, pos?: number, options?: Options): ESTree.Expression;
 
     interface ITokenizer {
-      getToken() : Token,
-      [Symbol.iterator](): Iterator<Token>
+      getToken(): Token;
+      [Symbol.iterator](): Iterator<Token>;
     }
-  
+
     function tokenizer(input: string, options: Options): ITokenizer;
 
     let parse_dammit: IParse | undefined;
@@ -250,12 +247,10 @@ declare namespace acorn {
     let pluginsLoose: PluginsObject | undefined;
 
     interface ILooseParserClass {
-        new (input: string, options?: Options): ILooseParser
+        new (input: string, options?: Options): ILooseParser;
     }
 
-    interface ILooseParser {
-
-    }
+    interface ILooseParser {}
 
     function addLooseExports(parse: IParse, parser: ILooseParserClass, plugins: PluginsObject): void;
 }

types/acorn/tslint.json

@@ -1,79 +1,9 @@
 {
     "extends": "dtslint/dt.json",
     "rules": {
-        "adjacent-overload-signatures": false,
-        "array-type": false,
-        "arrow-return-shorthand": false,
-        "ban-types": false,
-        "callable-types": false,
-        "comment-format": false,
-        "dt-header": false,
-        "eofline": false,
         "export-just-namespace": false,
-        "import-spacing": false,
         "interface-name": false,
-        "interface-over-type-literal": false,
-        "jsdoc-format": false,
-        "max-line-length": false,
-        "member-access": false,
-        "new-parens": false,
-        "no-any-union": false,
-        "no-boolean-literal-compare": false,
-        "no-conditional-assignment": false,
-        "no-consecutive-blank-lines": false,
-        "no-construct": false,
-        "no-declare-current-package": false,
-        "no-duplicate-imports": false,
-        "no-duplicate-variable": false,
         "no-empty-interface": false,
-        "no-for-in-array": false,
-        "no-inferrable-types": false,
-        "no-internal-module": false,
-        "no-irregular-whitespace": false,
-        "no-mergeable-namespace": false,
-        "no-misused-new": false,
-        "no-namespace": false,
-        "no-object-literal-type-assertion": false,
-        "no-padding": false,
-        "no-redundant-jsdoc": false,
-        "no-redundant-jsdoc-2": false,
-        "no-redundant-undefined": false,
-        "no-reference-import": false,
-        "no-relative-import-in-test": false,
-        "no-self-import": false,
-        "no-single-declare-module": false,
-        "no-string-throw": false,
-        "no-unnecessary-callback-wrapper": false,
-        "no-unnecessary-class": false,
-        "no-unnecessary-generics": false,
-        "no-unnecessary-qualifier": false,
-        "no-unnecessary-type-assertion": false,
-        "no-useless-files": false,
-        "no-var-keyword": false,
-        "no-var-requires": false,
-        "no-void-expression": false,
-        "no-trailing-whitespace": false,
-        "object-literal-key-quotes": false,
-        "object-literal-shorthand": false,
-        "one-line": false,
-        "one-variable-per-declaration": false,
-        "only-arrow-functions": false,
-        "prefer-conditional-expression": false,
-        "prefer-const": false,
-        "prefer-declare-function": false,
-        "prefer-for-of": false,
-        "prefer-method-signature": false,
-        "prefer-template": false,
-        "radix": false,
-        "semicolon": false,
-        "space-before-function-paren": false,
-        "space-within-parens": false,
-        "strict-export-declare-modifiers": false,
-        "trim-file": false,
-        "triple-equals": false,
-        "typedef-whitespace": false,
-        "unified-signatures": false,
-        "void-return": false,
-        "whitespace": false
+        "no-unnecessary-class": false
     }
 }