vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-08-12 13:00:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #10763 from alejo90/node-buffer-lastIndexOf-and-indexOf

Browse Source 
Made node Buffer's lastIndexOf and indexOf conformant to node API
This commit is contained in:
Ron Buckton
2016-08-23 10:08:41 -07:00
committed by GitHub
parent 73e7125348 69ecb66f73
commit c75674c0a0
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
node/node-tests.ts
+11
View File
@@ -244,10 +244,21 @@ function bufferTests() {
let index: number;
index = buffer.indexOf("23");
index = buffer.indexOf("23", 1);
index = buffer.indexOf("23", 1, "utf8");
index = buffer.indexOf(23);
index = buffer.indexOf(buffer);
}
{
let buffer = new Buffer('123');
let index: number;
index = buffer.lastIndexOf("23");
index = buffer.lastIndexOf("23", 1);
index = buffer.lastIndexOf("23", 1, "utf8");
index = buffer.lastIndexOf(23);
index = buffer.lastIndexOf(buffer);
}
// Imported Buffer from buffer module works properly
{
let b = new ImportedBuffer('123');
node/node.d.ts
Vendored
+2 -2
View File
@@ -503,8 +503,8 @@ interface NodeBuffer extends Uint8Array {
writeDoubleLE(value: number, offset: number, noAssert?: boolean): number;
writeDoubleBE(value: number, offset: number, noAssert?: boolean): number;
fill(value: any, offset?: number, end?: number): this;
// TODO: encoding param
indexOf(value: string | number | Buffer, byteOffset?: number): number;
indexOf(value: string | number | Buffer, byteOffset?: number, encoding?: string): number;
lastIndexOf(value: string | number | Buffer, byteOffset?: number, encoding?: string): number;
// TODO: entries
// TODO: includes
// TODO: keys