Merge pull request #33140 from erik-beus/menuitem-value

Allow any for value prop on MenuItem in react-aria-menubutton

types/react-aria-menubutton/index.d.ts

@@ -1,4 +1,4 @@
-// Type definitions for react-aria-menubutton 6.1
+// Type definitions for react-aria-menubutton 6.2
 // Project: https://github.com/davidtheclark/react-aria-menubutton
 // Definitions by: Muhammad Fawwaz Orabi <https://github.com/forabi>
 //                 Chris Rohlfs <https://github.com/crohlfs>
@@ -100,7 +100,7 @@ export interface MenuItemProps<T extends HTMLElement>
 	 * If value has a value, it will be passed to the onSelection handler
 	 * when the `MenuItem` is selected
 	 */
-	value?: string | boolean | number;
+	value?: any;
 
 	/**
 	 * If `text` has a value, its first letter will be the letter a user can

types/react-aria-menubutton/react-aria-menubutton-tests.tsx

@@ -121,3 +121,18 @@ closeMenu("", { focusMenu: true });
 
 openMenu("");
 openMenu("", { focusMenu: true });
+
+class ObjectMenuItem extends React.Component {
+	render() {
+		const itemValue = { name: "Test name", label: "Only item to select" };
+		return (
+			<Wrapper onSelection={(value) => console.log(value.name)}>
+				<li>
+					<MenuItem value={itemValue} >{itemValue.label}</MenuItem>
+				</li>
+			</Wrapper>
+		);
+	}
+}
+
+ReactDOM.render(<ObjectMenuItem />, document.body);