vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-08-13 05:20:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

corrected: in async.queue.push(task,callback) callback is not called with the task interface. (#18821)

Browse Source 
* correted: async.queue callback function does not use task interface.

* correct `queue.push` generic type.
This commit is contained in:
Sasan
2017-08-14 15:08:23 -07:00
committed by Mohamed Hegazy
parent ec574e7dad
commit ccb1510ac1
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
types/async/index.d.ts
Vendored
+3 -3
View File
@@ -28,7 +28,7 @@ interface AsyncQueue<T> {
idle(): boolean;
concurrency: number;
push<E>(task: T, callback?: ErrorCallback<E>): void;
push<E>(task: T, callback?: AsyncResultCallback<T, E>): void;
push<R,E>(task: T, callback?: AsyncResultCallback<R, E>): void;
push<E>(task: T[], callback?: ErrorCallback<E>): void;
unshift<E>(task: T, callback?: ErrorCallback<E>): void;
unshift<E>(task: T[], callback?: ErrorCallback<E>): void;
@@ -53,8 +53,8 @@ interface AsyncPriorityQueue<T> {
concurrency: number;
started: boolean;
paused: boolean;
push<E>(task: T, priority: number, callback?: AsyncResultArrayCallback<T, E>): void;
push<E>(task: T[], priority: number, callback?: AsyncResultArrayCallback<T, E>): void;
push<R,E>(task: T, priority: number, callback?: AsyncResultArrayCallback<R, E>): void;
push<R,E>(task: T[], priority: number, callback?: AsyncResultArrayCallback<R, E>): void;
saturated: () => any;
empty: () => any;
drain: () => any;
types/async/test/index.ts
+6 -2
View File
@@ -271,9 +271,9 @@ async.waterfall([
], function (err, result) { });
var q = async.queue<any,Error>(function (task: any, callback: () => void) {
var q = async.queue<any,Error>(function (task: any, callback: (err?:Error,msg?:string) => void) {
console.log('hello ' + task.name);
callback();
callback(undefined,'a message.');
}, 2);
@@ -291,6 +291,10 @@ q.push([{ name: 'baz' }, { name: 'bay' }, { name: 'bax' }], function (err) {
console.log('finished processing bar');
});
q.push<string,Error>({name: 'foo'}, function (err,msg) {
console.log('foo finished with a message "'+ msg! + '"');
});
q.unshift({ name: 'foo' });
q.unshift({ name: 'bar' }, function (err) {