vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-08-11 12:30:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

infrastructure: naming review for Print functions

Browse Source
This commit is contained in:
basarat
2013-11-10 19:49:57 +11:00
parent ef2d61cff4
commit dbb2bb6b15
2 changed files with 34 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
_infrastructure/tests/runner.js
+17 -17
View File
@@ -719,19 +719,19 @@ var DefinitelyTyped;
this.out(' \33[36m\33[1mTypeScript files :\33[0m ' + this.tsFiles + '\n');
};
Print.prototype.printSyntaxChecking = function () {
Print.prototype.printSyntaxCheckingHeader = function () {
this.out('============================ \33[34m\33[1mSyntax checking\33[0m ================================\n');
};
Print.prototype.printTypingTests = function () {
Print.prototype.printTypingTestsHeader = function () {
this.out('============================= \33[34m\33[1mTyping tests\33[0m ==================================\n');
};
Print.prototype.printSuccess = function () {
Print.prototype.printSuccessCharacter = function () {
this.out('\33[36m\33[1m.\33[0m');
};
Print.prototype.printFailure = function () {
Print.prototype.printFailureCharacter = function () {
this.out('x');
};
@@ -763,7 +763,7 @@ var DefinitelyTyped;
this.out(' - \33[33m\33[1m' + file + '\33[0m\n');
};
Print.prototype.breack = function () {
Print.prototype.printBreak = function () {
this.out('\n');
};
@@ -874,10 +874,10 @@ var DefinitelyTyped;
if (!endsWith(file.toUpperCase(), '-TESTS.TS') && endsWith(file.toUpperCase(), '.TS') && file.indexOf('../_infrastructure') < 0) {
new Test(file).run(function (execResult) {
if (execResult.exitCode === 1) {
_this.out.printFailure();
_this.out.printFailureCharacter();
len++;
} else {
_this.out.printSuccess();
_this.out.printSuccessCharacter();
len++;
}
@@ -885,13 +885,13 @@ var DefinitelyTyped;
if (len > maxLen) {
len = 0;
_this.out.breack();
_this.out.printBreak();
}
if (it.hasNext()) {
_this.run(it, it.next(), len, maxLen, callback);
} else {
_this.out.breack();
_this.out.printBreak();
_this.timer.end();
_this.printFailedFiles();
_this.printStats();
@@ -902,7 +902,7 @@ var DefinitelyTyped;
} else if (it.hasNext()) {
this.run(it, it.next(), len, maxLen, callback);
} else {
this.out.breack();
this.out.printBreak();
this.timer.end();
this.printStats();
this.printFailedFiles();
@@ -989,10 +989,10 @@ var DefinitelyTyped;
if (endsWith(file.toUpperCase(), '-TESTS.TS')) {
new Test(file).run(function (execResult) {
if (execResult.exitCode === 1) {
_this.out.printFailure();
_this.out.printFailureCharacter();
len++;
} else {
_this.out.printSuccess();
_this.out.printSuccessCharacter();
len++;
}
@@ -1000,13 +1000,13 @@ var DefinitelyTyped;
if (len > maxLen) {
len = 0;
_this.out.breack();
_this.out.printBreak();
}
if (it.hasNext()) {
_this.run(it, it.next(), len, maxLen, callback);
} else {
_this.out.breack();
_this.out.printBreak();
_this.timer.end();
_this.printFailedFiles();
_this.printStats();
@@ -1017,7 +1017,7 @@ var DefinitelyTyped;
} else if (it.hasNext()) {
this.run(it, it.next(), len, maxLen, callback);
} else {
this.out.breack();
this.out.printBreak();
this.timer.end();
this.printFailedFiles();
this.printStats();
@@ -1092,10 +1092,10 @@ var DefinitelyTyped;
this.out.printHeader();
// Run syntax tests
this.out.printSyntaxChecking();
this.out.printSyntaxCheckingHeader();
this.sc.start(function (syntaxFailedCount, syntaxTotal) {
// Now run typing tests
_this.out.printTypingTests();
_this.out.printTypingTestsHeader();
_this.te.start(function (testFailedCount, testTotal) {
// Get the tests without any typing and simultaneously print their names
var totalTypingsWithoutTest = _this.printTypingsWithoutTest();
_infrastructure/tests/runner.ts
+17 -17
View File
@@ -169,19 +169,19 @@ module DefinitelyTyped.TestManager {
this.out(' \33[36m\33[1mTypeScript files :\33[0m ' + this.tsFiles + '\n');
}
public printSyntaxChecking() {
public printSyntaxCheckingHeader() {
this.out('============================ \33[34m\33[1mSyntax checking\33[0m ================================\n');
}
public printTypingTests() {
public printTypingTestsHeader() {
this.out('============================= \33[34m\33[1mTyping tests\33[0m ==================================\n');
}
public printSuccess() {
public printSuccessCharacter() {
this.out('\33[36m\33[1m.\33[0m');
}
public printFailure() {
public printFailureCharacter() {
this.out('x');
}
@@ -213,7 +213,7 @@ module DefinitelyTyped.TestManager {
this.out(' - \33[33m\33[1m' + file + '\33[0m\n');
}
public breack() {
public printBreak() {
this.out('\n');
}
@@ -325,10 +325,10 @@ module DefinitelyTyped.TestManager {
new Test(file).run((execResult) => {
if (execResult.exitCode === 1) {
this.out.printFailure();
this.out.printFailureCharacter();
len++;
} else {
this.out.printSuccess();
this.out.printSuccessCharacter();
len++;
}
@@ -336,13 +336,13 @@ module DefinitelyTyped.TestManager {
if (len > maxLen) {
len = 0;
this.out.breack();
this.out.printBreak();
}
if (it.hasNext()) {
this.run(it, it.next(), len, maxLen, callback);
} else {
this.out.breack();
this.out.printBreak();
this.timer.end();
this.printFailedFiles();
this.printStats();
@@ -353,7 +353,7 @@ module DefinitelyTyped.TestManager {
} else if (it.hasNext()) {
this.run(it, it.next(), len, maxLen, callback);
} else {
this.out.breack();
this.out.printBreak();
this.timer.end();
this.printStats();
this.printFailedFiles();
@@ -442,10 +442,10 @@ module DefinitelyTyped.TestManager {
new Test(file).run((execResult) => {
if (execResult.exitCode === 1) {
this.out.printFailure();
this.out.printFailureCharacter();
len++;
} else {
this.out.printSuccess();
this.out.printSuccessCharacter();
len++;
}
@@ -453,13 +453,13 @@ module DefinitelyTyped.TestManager {
if (len > maxLen) {
len = 0;
this.out.breack();
this.out.printBreak();
}
if (it.hasNext()) {
this.run(it, it.next(), len, maxLen, callback);
} else {
this.out.breack();
this.out.printBreak();
this.timer.end();
this.printFailedFiles();
this.printStats();
@@ -470,7 +470,7 @@ module DefinitelyTyped.TestManager {
} else if (it.hasNext()) {
this.run(it, it.next(), len, maxLen, callback);
} else {
this.out.breack();
this.out.printBreak();
this.timer.end();
this.printFailedFiles();
this.printStats();
@@ -552,11 +552,11 @@ module DefinitelyTyped.TestManager {
this.out.printHeader();
// Run syntax tests
this.out.printSyntaxChecking();
this.out.printSyntaxCheckingHeader();
this.sc.start((syntaxFailedCount, syntaxTotal) => {
// Now run typing tests
this.out.printTypingTests();
this.out.printTypingTestsHeader();
this.te.start((testFailedCount, testTotal) => {
// Get the tests without any typing and simultaneously print their names