vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-10-05 07:17:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #33432 from oriSomething/electron-store

Browse Source 
electron-store - Fix `onDidChange` return value defition
This commit is contained in:
Nathan Shively-Sanders
2019-03-07 07:54:50 -08:00
committed by GitHub
parent ea11da4453 e5f8ae3234
commit eaf8f697c5
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
types/electron-store/electron-store-tests.ts
+4
View File
@@ -52,3 +52,7 @@ typedElectronStore.set({
enabled: true,
interval: 10000,
});
const offDidChange = typedElectronStore.onDidChange("enabled", (n: boolean | undefined, p: boolean | undefined) => {});
offDidChange();
types/electron-store/index.d.ts
Vendored
+6 -4
View File
@@ -8,6 +8,8 @@
/// <reference types="node" />
import EventEmitter = require("events");
type JSONValue = string | number | boolean | JSONObject | JSONArray;
interface JSONObject {
@@ -79,12 +81,12 @@ declare class ElectronStore<T = {}> implements Iterable<[string, JSONValue]> {
*/
onDidChange<K extends keyof T>(
key: K,
callback: (newValue: T[K], oldValue: T[K]) => void
): void;
callback: (newValue: T[K] | undefined, oldValue: T[K] | undefined) => void
): () => EventEmitter;
onDidChange(
key: string,
callback: (newValue: JSONValue, oldValue: JSONValue) => void
): void;
callback: (newValue: JSONValue | undefined, oldValue: JSONValue | undefined) => void
): () => EventEmitter;
/**
* Get the item count.