[cote] add error argument to responder on callback for cote package (#29159)

* add error argument to responder on callback

* Update index.d.ts

* Update index.d.ts

add line 286 to allow custom property on Event type.

* Revert previous commit

Revert commit [a1111453a600b7fbb3576fca3405849026a537b2](a1111453a6)

* Edit send callback

* Fix send callback
This commit is contained in:
robin labat
2018-10-02 06:06:13 +02:00
committed by Wesley Wigham
parent 92b222f89c
commit ec515fa8df
2 changed files with 6 additions and 5 deletions

View File

@@ -80,10 +80,10 @@ class Readme {
payload: { val: number };
}
randomResponder.on('randomRequest', (req: RandomRequest, callback: (answer: number) => void) => {
randomResponder.on('randomRequest', (req: RandomRequest, callback: (error: any, answer?: number) => void) => {
const answer = Math.floor(Math.random() * 10);
console.log('request', req.payload.val, 'answering with', answer);
callback(answer);
callback(null, answer);
});
}

View File

@@ -1,6 +1,7 @@
// Type definitions for cote 0.14
// Type definitions for cote 0.17
// Project: https://github.com/dashersw/cote#readme
// Definitions by: makepost <https://github.com/makepost>
// Labat Robin <https://github.com/roblabat>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
import { EventEmitter2 } from "eventemitter2";
@@ -55,7 +56,7 @@ export class Requester extends Component {
* @param event Request.
* @param callback Function to execute after getting a result.
*/
send<T extends Event>(event: T, callback: (result: any) => void): void;
send<T extends Event>(event: T, callback: (error: any, result: any) => void): void;
}
/**
@@ -100,7 +101,7 @@ export class Responder extends Component {
on<T extends Event>(
type: string | string[],
listener: (
((event: T, callback: (result: any) => void) => void) |
((event: T, callback: (error: any, result: any) => void) => void) |
((event: T) => Promise<any>)
)
): this;