Respond to PR comments

This commit is contained in:
Andy Hanson
2016-12-27 12:12:25 -08:00
parent f14833b4cc
commit eee771c330
+5 -4
View File
@@ -6,19 +6,20 @@ Please fill in this template.
- [ ] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped#make-a-pull-request).
- [ ] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped#common-mistakes).
- [ ] Run `tsc` without errors.
- [ ] Run `npm run lint -- package-name` if a `tslint.json` is present.
- [ ] Run `npm run lint package-name` if a `tslint.json` is present.
Select one of these and delete the others:
If adding a new definition:
- [ ] The package does not provide its own types, and you can not add them.
- [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
- [ ] Create it with `npm run new-package -- foo`, not by basing it on an existing project.
- [ ] Create it with `npm run new-package package-name`, not by basing it on an existing project.
If changing an existing definition:
- [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>
- [ ] Increase the version number in the header if appropriate.
If removing a definition:
- [ ] Delete the package's directory. (If it's not on DefinitelyTyped, you don't need to delete it.)
If removing a declaration:
- [ ] If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
- [ ] Delete the package's directory.
- [ ] Add it to `notNeededPackages.json`.