Merge pull request #28912 from osdiab/osdiab-react-mailchimp-subscribe-tests

react-mailchimp-subscribe: uncomment tests that failed in versions prior to tsc 2.9
This commit is contained in:
Armando Aguirre
2018-11-05 11:23:20 -08:00
committed by GitHub
2 changed files with 3 additions and 5 deletions
+1 -1
View File
@@ -2,7 +2,7 @@
// Project: https://revolunet.github.io/react-mailchimp-subscribe/
// Definitions by: Omar Diab <https://github.com/osdiab>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// TypeScript Version: 2.8
// TypeScript Version: 2.9
import { Component, ReactNode } from "react";
@@ -25,9 +25,7 @@ const Example: React.StatelessComponent = () => (
</>)}
url="spam.biz/subscribe"
/>
{ /* once Typescript 2.9 is out, generics in components will be allowed, at that point uncomment these. */ }
{ /* https://github.com/Microsoft/TypeScript/pull/22415 */ }
{/* <MailchimpSubscribe<any>
<MailchimpSubscribe<any>
render={(hooks) => (
<form
onSubmit={e => {
@@ -52,6 +50,6 @@ const Example: React.StatelessComponent = () => (
/>
)}
url="spam.biz/subscribe"
/> */}
/>
</>
);