vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-10-04 23:07:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove node dependencies from react

Browse Source
This commit is contained in:
Ron Buckton
2018-11-27 11:08:56 -08:00
parent 994038d60c
commit f961f35307
2 changed files with 32 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files
types/react/test/index.ts
+16 -30
View File
@@ -14,23 +14,6 @@ import update = require("react-addons-update");
import createReactClass = require("create-react-class");
import * as DOM from "react-dom-factories";
// forward declarations (avoids an unnecessary dependency on NodeJS)
declare global {
interface Console {
log(message?: any, ...optionalParams: any[]): void;
}
var console: Console;
function setInterval(callback: (...args: any[]) => void, ms: number, ...args: any[]): NodeJS.Timeout;
function clearInterval(intervalId: NodeJS.Timeout): void;
namespace NodeJS {
// tslint:disable-next-line:no-empty-interface
interface Timer {}
interface Timeout extends Timer {}
}
}
interface Props extends React.Attributes {
hello: string;
world?: string | null;
@@ -103,7 +86,7 @@ declare const container: Element;
render() { return null; }
componentDidMount() {
// $ExpectError -> this will be true in next BC release where state is gonna be `null | Readonly<S>`
console.log(this.state.inputValue);
this.state.inputValue;
}
mutateState() {
// $ExpectError
@@ -184,7 +167,7 @@ class ModernComponent extends React.Component<Props, State, Snapshot>
value: this.state.inputValue ? this.state.inputValue : undefined
}),
DOM.input({
onChange: event => console.log(event.target)
onChange: event => event.target
}));
}
@@ -518,17 +501,20 @@ class Timer extends React.Component<{}, TimerState> {
state = {
secondsElapsed: 0
};
private _interval: NodeJS.Timer;
// NOTE: creates unnecessary dependency on 'node'. leaving for reference purposes
// private _interval: NodeJS.Timer;
tick() {
this.setState((prevState, props) => ({
secondsElapsed: prevState.secondsElapsed + 1
}));
}
componentDidMount() {
this._interval = setInterval(() => this.tick(), 1000);
// NOTE: creates unnecessary dependency on 'node'. leaving for reference purposes
// this._interval = setInterval(() => this.tick(), 1000);
}
componentWillUnmount() {
clearInterval(this._interval);
// NOTE: creates unnecessary dependency on 'node'. leaving for reference purposes
// clearInterval(this._interval);
}
render() {
return DOM.div(
@@ -615,14 +601,14 @@ Perf.printExclusive();
Perf.printWasted();
Perf.printOperations();
console.log(Perf.getExclusive());
console.log(Perf.getInclusive());
console.log(Perf.getWasted());
console.log(Perf.getOperations());
console.log(Perf.getExclusive(measurements));
console.log(Perf.getInclusive(measurements));
console.log(Perf.getWasted(measurements));
console.log(Perf.getOperations(measurements));
Perf.getExclusive();
Perf.getInclusive();
Perf.getWasted();
Perf.getOperations();
Perf.getExclusive(measurements);
Perf.getInclusive(measurements);
Perf.getWasted(measurements);
Perf.getOperations(measurements);
// Renamed to printOperations(). Please use it instead.
Perf.printDOM(measurements);
types/react/v15/test/index.ts
+16 -13
View File
@@ -120,7 +120,7 @@ class ModernComponent extends React.Component<Props, State>
value: this.state.inputValue
}),
React.DOM.input({
onChange: event => console.log(event.target)
onChange: event => event.target
}));
}
@@ -342,7 +342,7 @@ const htmlAttr: React.HTMLProps<HTMLElement> = {
event.stopPropagation();
},
onAnimationStart: event => {
console.log(event.currentTarget.className);
event.currentTarget.className;
},
dangerouslySetInnerHTML: {
__html: "<strong>STRONG</strong>"
@@ -505,17 +505,20 @@ class Timer extends React.Component<{}, TimerState> {
state = {
secondsElapsed: 0
};
private _interval: NodeJS.Timer;
// NOTE: creates unnecessary dependency on 'node'. leaving for reference purposes
// private _interval: NodeJS.Timer;
tick() {
this.setState((prevState, props) => ({
secondsElapsed: prevState.secondsElapsed + 1
}));
}
componentDidMount() {
this._interval = setInterval(() => this.tick(), 1000);
// NOTE: creates unnecessary dependency on 'node'. leaving for reference purposes
// this._interval = setInterval(() => this.tick(), 1000);
}
componentWillUnmount() {
clearInterval(this._interval);
// NOTE: creates unnecessary dependency on 'node'. leaving for reference purposes
// clearInterval(this._interval);
}
render() {
return React.DOM.div(
@@ -602,14 +605,14 @@ Perf.printExclusive();
Perf.printWasted();
Perf.printOperations();
console.log(Perf.getExclusive());
console.log(Perf.getInclusive());
console.log(Perf.getWasted());
console.log(Perf.getOperations());
console.log(Perf.getExclusive(measurements));
console.log(Perf.getInclusive(measurements));
console.log(Perf.getWasted(measurements));
console.log(Perf.getOperations(measurements));
Perf.getExclusive();
Perf.getInclusive();
Perf.getWasted();
Perf.getOperations();
Perf.getExclusive(measurements);
Perf.getInclusive(measurements);
Perf.getWasted(measurements);
Perf.getOperations(measurements);
// Renamed to printOperations(). Please use it instead.
Perf.printDOM(measurements);