* espruino added type for wifi module for access point
* espruino added myself to definitions
* changed tabsize to 4
* espruino: added boolean to digitalwrite
* Fixed type for function passing to cors() origin
If you look at the actual code within @koa/cors and where it invokes any passed function within the origin: option, it invokes it with ctx, the standard Koa context, NOT the Request. Here is the code fragment..
https://github.com/koajs/cors/blob/b5a937fc24666761c61b1ac633f49f54612d1315/index.js#L58
Thus changed the signature of the origin option to reflect this.
* Revert back to single quotes -- stupid prettier
Fixed type for function passing to cors() origin
If you look at the actual code within @koa/cors and where it invokes any passed function within the origin: option, it invokes it with ctx, the standard Koa context, NOT the Request. Here is the code fragment..
https://github.com/koajs/cors/blob/b5a937fc24666761c61b1ac633f49f54612d1315/index.js#L58
Thus changed the signature of the origin option to reflect this.
This was added to DefinitelyTyped in PRs #21204 and #24041. However,
both reasons given are incorrect: this prop is indeed featured in the
examples, but only used for a sample component also defined for demo
purposes. `props.label` is not a part of the `redux-form` `<Field/>`
API, and as such shouldn't be included.
One reason is because `props.label` should be up to users to implement.
If a user wants `props.label` to support React nodes instead of just
strings, they can no longer just extend DefinitelyTyped interfaces
because this causes an incompatibility with the set string type.
I realize this change might cause backwards compatibility issues for
users who are already using a `label` prop, as it's a ubiquitous
pattern. Looking for input on how to properly proceed with this. Thanks!
------
Please fill in this template.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change. (Run with `npm test`.) *NOTE: I am getting `File name must be camelCase` both before and after my change*
- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).
- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).
- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).
Select one of these and delete the others:
If changing an existing definition:
- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/erikras/redux-form/blob/master/src/createField.js ctrl-F label; no result
- [ ] Increase the version number in the header if appropriate.
- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ "extends": "dtslint/dt.json" }`.
* Add ability for arrow renderer prop to be set to null
In this issue, arrow rendering would keep the functionality even if no arrow was being rendered.
The PR below fixed the issue.
https://github.com/JedWatson/react-select/pull/1761
In this PR, the guys added the ability to set the arrowRenderer option to null, which disables all arrow related operation.
The types repo needs to reflect this change.
Thanks!
* Add my name to list
* Updated `web3.utils.toWei()` Unit list and added default Unit value
* edit tests for tslint
* web3: reordered ether Unit list to match official docs
* web3 tests improvement
* Add property zoomControl to class Map
Leaflet has a map property called zoomControl. This is useful for setting the position on these controls for the map. This is not available via the typings.
Example usage:
map.zoomControl.setPosition('topright');
* Leaflet: Map.zoomControl property
Specify Map.zoomControl type more precisely as Control.Zoom
* Fix typing error in PolygonGraphics
The property outlineColor of PolygonGraphics can accept both Property and Color types.
[Discussion on AnalyticalGraphicsInc/cesium](https://github.com/AnalyticalGraphicsInc/cesium/issues/6831)
* Update version
* Removed the Color type from outlineColor typedef.
Melvin Groenhoff