I had two PRs merge close together that caused the build to fail.
- #22809 fixed a bug
- #22821 removed all the overrides from `tslint.json`
Unfortunately, the former ended up with a couple lint issues.
```
./types/request/index.d.ts
ERROR: 64:20 unified-signatures This overload and the one on line 63
can be combined into one signature taking `string | RequiredUriUrl &
TOptions`.
./types/request/request-tests.ts
ERROR: 10:5 prefer-const Identifier 'value' is never
reassigned; use 'const' instead of 'let'.
```
Please fill in this template.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).
- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).
- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).
Select one of these and delete the others:
If changing an existing definition:
- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/facebook/react-native/blob/master/Libraries/Modal/Modal.js#L161
Additional info:
Just like the onShow optional prop, the Modal's onOrientationChange prop can capture a NativeSyntheticEvent at the time of the hardware change. This allows the developer to determine if the orientation change was to the landscape or portrait style and react accordingly.
* Update mapbox-gl and geojson types
* Make geojson coordinates optional
* Increase mapbox type header
* Remove changes of GeometryObject and use internal mapbox any geometry type
* Update metadata
* Add IUpsertOptions interface
* Add upsertAttachment method overloads
* Add upsertDocument method overloads
* Update test metadata
* Remove old stored procedure samples from tests
* Add comments for extra tests that cannot currently be added
* Update author name format to match convention
* Add missing overloads to ICollection.queryDocuments with type parameters
Added additional properties that were missing
Changed CalendarEvent to type any, since this could be anything based on what the user is using for their event
Added specific types for View, Navigate, Format
Updated other types and functions that were incorrect with the current version of the package.
Two changes:
1) We are now allowing the parameters of a request to be typed. This
adds more type safety to consumers.
2) We support optional parameters in the request.
For (2), the root cause is this issue in how Typescript handles
--strictNullChecking:
https://github.com/Microsoft/TypeScript/issues/9235
* @types/ws: Update types definition for ws@4.0
* @types/ws Update type definition for ws@4.0
- Change extensions attribute type
- Rename headers event to upgrade
* @types/ws - Updage ws tests to be in sync with ws@4.0.0
* missing comment
* missing comment
* add iteratee property shorthand for uniq in underscore
* undo bad commit
* can also pass array of array of data to chartist
* First update to bring the mongodb typings to version 3
* Updated tsconfig of the older v2 version
* Set mongodb version to 2 in packages with errors
* MongoClient extends form EventEmitter
Michael Zlatkovsky