The `StyleSystemObject` contains a few union types that aren't being publicly exported. This was causing errors when trying to use the `SystemStyleObject` in external projects.
Exporting the `CSSSelectorObject`, `VariantProperty`, and `UseThemeFunction` to allow external use of the `StyleSystemObject` type.
The exported `Theme` interface throws a reference error when attempting to use within another project. This is due to not exporting the `ThemeBreakPoints` type.
* 🐛 change schema to scheme (typo)
* ✅ add test for SourceProp scheme
* ✅ add source and layer for raster tiles in test
* 🔥 remove scheme from geojson source
* 🐛 use correct source id in layer test
* [@types/pdfmake] Split definitions
pdfmake/index.d.ts will only export the node api.
pdfmake/interfaces.d.ts will contain all data types
pdfmake/build/pdfmake.d.ts will export the browser module api as well as the global namespace object
pdfmake/build/vfs_fonts.d.ts will export the vfs for the browser
* [@types/pdfmake] Add type references for node and pdfkit
* [@types/pdfmake] Remove enums
TypeScript enums exist at runtime and should never be used in type declaration files unless they perfectly describe the behaviour of the JS code (which is highly unlikely). pdfMake only expects string literals, so the enums were modeled as unions of string literals.
* [@types/pdfmake] Overhaul interfaces
All changes were meticulously verified against the official docs, the examples AND the source code. Since the documentation is incomplete, the only real spec I had to work with was the actual implementation, which is less than ideal.
* [@types/pdfmake] Update server and browser api files
The server api exposes a class as single export object. This means the `export =` syntax is necessary for the type definitions, and the consumers must import the module with an `import PdfPrinter = require('pdfmake')` statement.
The browser api expose both a compliant ES6 module and a global 'pdfMake' object, which is why the 'export as namespace' syntax is necessary.
* [@types/pdfmake] Update tests
The examples provided by the pdfMake playground and repository are all copied in pdfmake-playground-examples-tests.ts and pdfmake-examples-test.ts respectively.
The pdfmake-interfaces-tests.ts contains code from the documentation as well as additionnal tests for coverage.
The other files test all different flavors of the api.
* [@types/pdfmake] Add myself as maintainer
* [@types/pdfmake] Layout long union type
* [@types/pdfmake] Add PageBreak union type
* [@types/pdfmake] Add doc comments
* [@types/pdfmake] Fix typo
* [bent] Add `dom` as a triple-slash reference
For some reason including dom in the lib doesn't appear to work, and tsc throws an error if the user doesn't include `dom` in their own project.
* [bent] Bump minimum TypeScript ver
Please fill in this template.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change. (Run with `npm test`.)
- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).
- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).
- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).
Select one of these and delete the others:
If changing an existing definition:
- [x] Provide a URL to documentation or source code which provides context for the suggested changes: #31065, #39062
- [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ "extends": "dtslint/dt.json" }`. If for reason the any rule need to be disabled, disable it for that line using `// tslint:disable-next-line [ruleName]` and not for whole package so that the need for disabling can be reviewed.
Fixes #39062
This will allow typechecking and autocompletion for events
inherited from stream.Readable and stream.Writable.
Also add missing 'ready' event and `pending` field from Node 9 and 11, respectively.
And missing 'pause' and 'resume' events on stream.Readable.
Matthew Leffler