Users write code like:
angular.element(window)
angular.element($window) // IWindowService
but this fails with a type error under TypeScript 3.5, due to a change
in the type of of Window. (Previously the only reason it compiled is
that Window was matching the ArrayLike<Element> param.)
Note that if you run the tests, the definition of JQueryStatic here
in the JQLite typings declaration-merges with the full JQuery
definition, which accepts any (!) so there is no type error. But if
you use just this library without JQuery, the type errors without my
fix look like:
angular-tests.ts:788:17 - error TS2345: Argument of type 'Window' is not assignable to parameter of type 'string | Element | Document | JQuery | ArrayLike<Element> | (() => void)'.
Type 'Window' is missing the following properties from type 'Document': activeElement, alinkColor, all, anchors, and 147 more.
788 angular.element(window);
~~~~~~
angular-tests.ts:790:17 - error TS2345: Argument of type 'IWindowService' is not assignable to parameter of type 'string | Element | Document | JQuery | ArrayLike<Element> | (() => void)'.
Type 'IWindowService' is missing the following properties from type 'Document': activeElement, alinkColor, all, anchors, and 147 more.
* Fixed the declaration file for the 'showButtons' prop, as it was previously 'showButton' and it couldn't be used effectively with Typescript
* fix-reactour-showButtons update test
* Make toposort properly generic and add missing array definition
* Add full documentation to toposort
* Make tuple not readonly, as it requires ts 3.4
* style fixes
* Add typescript version requirement to toposort
* export videojs.Player so it can be augmented
* lint
* in order to be augmentable, the VideoJsPlayer interface must actually be exported
* also export the PlayerOptions
* lint
* demonstrate augmentation actually works
* make linter happy
* Add type definitions for dialog-polyfill
* Remove self from code-owners list
Will be auto-generated and added.
* Simplify type definitions for dialog-polyfill
* Appease formatting-rules for dialog-polyfill type definitions
Without doing this, tsc complains that node_modules/@types/react-custom-scrollbars/index.d.ts is not a module
This change also allows importing Scrollbars as the module default `import Scrollbars from` or as a named export `import {Scollbars} from` because either work.
Documentation that this is a UMD module: https://github.com/malte-wessel/react-custom-scrollbars/commit/f632d08e725f30ac40cdb6257752ad36b40c6fef
* added beforeErrorHook type
* fixed formatting in test
* corrected beforeErrorHook implementation
* @types/got fixed unintended whitespace/style changes
* @types/got fixed remaining unintended style changes
* @types/got reduced to single error type
* @types/got removed doc from beforeErrorHook type as definition is obvious
VictoriaGreen93