* added beforeErrorHook type
* fixed formatting in test
* corrected beforeErrorHook implementation
* @types/got fixed unintended whitespace/style changes
* @types/got fixed remaining unintended style changes
* @types/got reduced to single error type
* @types/got removed doc from beforeErrorHook type as definition is obvious
* @types/got added timing interfaces to response interface
* Fix `cursorTo` requiring a `y` parameter
When `y` is omitted, `cursorTo` moves the cursor to the first character of the current line. When `y` is required, there is no way to use this capability of `cursorTo`.
* Re-add `cursorTo` test when not passing down `y` parameter
* [csp-html-webpack-plugin] Add type definitions.
* [csp-html-webpack-plugin] Fix test file formatting with Prettier.
* [csp-html-webpack-plugin] Move HtmlPluginData into exported namespace.
* [csp-html-webpack-plugin] Remove comment on HtmlPluginData.
* [csp-html-webpack-plugin] Use conditional types to figure out HtmlPluginData type.
* [csp-html-webpack-plugin] Remove 'esModuleInterop' from tsconfig.json.
There are a few optional arguments that can be passed to
the client methods that aren't present in the types currently.
I've added them as they are in the 2.3.0 version of the client
the existing types say they target.
- Change declaration style to reflect export style of js source, allow
instantiation of module
- Fix incorrect return type on set method
- Update tests to ensure correctness of changes
Fixing these strict compilation errors:
error TS7008: Member 'thumb' implicitly has an 'any' type.
error TS7006: Parameter 'e' implicitly has an 'any' type.
error TS7006: Parameter 'e' implicitly has an 'any' type.
Users write code like:
angular.element(window)
angular.element($window) // IWindowService
but this fails with a type error under TypeScript 3.5, due to a change
in the type of of Window. (Previously the only reason it compiled is
that Window was matching the ArrayLike<Element> param.)
Note that if you run the tests, the definition of JQueryStatic here
in the JQLite typings declaration-merges with the full JQuery
definition, which accepts any (!) so there is no type error. But if
you use just this library without JQuery, the type errors without my
fix look like:
angular-tests.ts:788:17 - error TS2345: Argument of type 'Window' is not assignable to parameter of type 'string | Element | Document | JQuery | ArrayLike<Element> | (() => void)'.
Type 'Window' is missing the following properties from type 'Document': activeElement, alinkColor, all, anchors, and 147 more.
788 angular.element(window);
~~~~~~
angular-tests.ts:790:17 - error TS2345: Argument of type 'IWindowService' is not assignable to parameter of type 'string | Element | Document | JQuery | ArrayLike<Element> | (() => void)'.
Type 'IWindowService' is missing the following properties from type 'Document': activeElement, alinkColor, all, anchors, and 147 more.
Tobias Krahn