- bump to version 3.9
- correct options for Minify compress options as it accepts only false
or configuration object as per JSDoc comment
- add JSDoc comments for Minify options
- minor addition to the tests
- remove TS version header line as no longer valid (current defaults to
TS 2.8 or newer)
https://github.com/mishoo/UglifyJS2/releases/tag/v3.9.0
Thanks!
This is minor change, providing support for UMD module, allowing to use
the definition file directly in other scenarios.
- definition file change with namespace export
- document library export
- split tests for CommonJS and global code tests
Usage is promoted as UMD module via CDN:
https://github.com/twitter/twemoji#cdn-support
Use-case:
- vanilla JS
- TS configured to not emit, check JS for errors:
```js
/// <reference types="twemoji" />
window.addEventListener('DOMContentLoaded', event => {
const div = document.createElement('div');
div.textContent = 'I \u2764\uFE0F emoji!';
document.body.appendChild(div);
twemoji.parse(document.body);
});
```
Thanks!
* fix: fixing the types for browse function results
* Added the missing reading_time to the PostOrPage type
* Introduces the BrowseResults (an array augmented with metadata)
* Included a Constructor function
BREAKING CHANGE: The following types are remapped as follows:
* `PostObject` --> `PostsOrPages`
* `AuthorsObject` --> `Authors`
* `TagsObject` --> `Tags`
* `Setting` --> `Settings`
* `SettingsObject` --> `SettingsResponse`
Partly inspired by this PR from Oliver Emery <https://github.com/thrymgjol>
* corrected line terminator
* code formatting corrected
Co-authored-by: Yashar Moradi <yashar.moradi@scoperty.de>
* Improve docs on 'testing' a dt module
* Duplicate saying how you can test your tests
* Apply suggestions from code review
Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
* Update docs with recommendations
* Apply suggestions from code review
Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
* Changes from reviews and link from the PR template
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
* no-op: Run prettier --write on react-router-dom.
* Allow correct "ref" to be passed Link.
"ref" can be used rather than "innerRef" to return a ref to the <a>
element inside of <Link>.
See:
[1]: reacttraining.com/react-router/web/api/Link/innerref-function
Where it says:
> As of React Router 5.1, if you are using React 16 you should not
> need this prop because we forward this ref to the underlying <a>.
> Use a normal ref instead.Allows access to the underlying ref of the
> component.
[2]: https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/modules/Link.js#L74-L121
Link is the result of forwardRef rather than an actual React class.
This implies a few things:
1. It is a function (see the return type of
React.ForwardRefExoticComponent) rather than a class
2. Its reference is to an inner <a> element, rather than what's in
React.Component, which is a Ref to the element itself.
This introduces a potential incompatibility where users can't use
"new Link" anymore. But that reflects reality (Link is callable not
newable).
Since Link was previously exported as a class, we need to continue to
support it being used as both a type and a value. Since Link was
exported as a generic, we need to continue to support that. As a result:
1. Link is exported as a function that happens to implement the type
corresponding to the result of
`forwardRef<HTMLAnchorElement, LinkProps<S>>`.
2. Link is still exported as a type (interface) which is the same as
that of the return value of `forwardRef<...>`.
* Make sure Link<S> can be used as a generic.
This is is only supported in TS >= 2.9.
I bumped the minimum TS supported version to 2.9 since 2.8 support ends this
month anyway.
* Apply prettier --write to tests.
* Apply same change (forwardRef) to NavLink.
1. https://reacttraining.com/react-router/web/api/NavLink
NavLink is a version of <Link> with the same props.
2. NavLink is similarly implemented in terms of forwardRef, so all
the justification from the previous commit applies. See:
https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/modules/NavLink.js
* To maintain TS 2.8 compatibility, use
React.createElement to test Link<{foo:number}>
and NavLink.
When TS 2.8 compatibility is no longer needed, this CL can be reverted
as-is.
Piotr Błażejewicz (Peter Blazejewicz)