Commit Graph
51372 Commits
Author SHA1 Message Date
Leonard ThieuandAndy abbce5d159 [jquery] Documentation improvements (#29658)
* [jquery] Fix code for example not rendering in VS Code autocomplete.

VS Code does not render the code block of the last example in the autocomplete tooltip (but does in the hover tooltip). This is fixed by adding an additional line terminated by a zero-width space. There doesn't appear to be an obvious pattern to what causes this and there may be other incidences of this bug in the declarations.

* [jquery] Improve formatting of documentation for unified signatures in tooltips.

Documentation for unified signatures is also unified. This means that documentation for a parameter will contain documentation from all the parameters that it's composed of. VS Code and WebStorm render this as one continuous line. This makes it confusing as it's not obvious which parts of documentation apply to a parameter.

To remedy this, parameters are formatted as a bulletted list. `<br>` tags are necessary to force line breaks in WebStorm. The list also cannot start on the first line. To force the first line break, the `<br>` tag is used for WebStorm. For VS Code, a non-empty body must follow the parameter name on its line. A Braille Pattern Blank could be used here but to provide a more intuitive and consistent experience, VS Code's format for rendering parameter info is mimicked instead. The `@` symbol must be encoded to prevent `@param` from being parsed as a JSDoc tag.

Note: VS Code renders the `<br>` tags literally and there does not appear to be a way to hide them.
2018-10-11 11:45:40 -07:00
Michal GrňoandAndy a38342addb [ascii2mathml] Export Options type (#29522)
* [ascii2mathml] Export Options type

Types should be exported.

* oops, forgot this

* one more try
2018-10-11 10:57:45 -07:00
Krishna GlickandAndy 124fddf61c Quill Options Fix to Match Documentation (#29545)
* Quill Options Fix to Match Documentation

https://quilljs.com/docs/api/#debug
Debug can take a string or boolean.

* Version Up

* CI Failed

* Adding test
2018-10-11 10:57:10 -07:00
Tim WeißenfelsandAndy e6526ac29b made tab change attention flag optional (#29523) 2018-10-11 10:56:57 -07:00
Quinn LangilleandAndy 4ec0f8dee0 New-Types: add types for Opossum (#29637) 2018-10-11 10:55:16 -07:00
João VieiraandAndy 05406773b8 Allow styles to be any ReactNode. (#29639) 2018-10-11 10:54:24 -07:00
YoshandAndy d59cfd4c35 [@types/react-native-auth0] add resetPassword definition (#29615) 2018-10-11 10:54:03 -07:00
Resi RespatiandAndy dab682e6f8 [next] Add support for next/constants (#29633)
* [next] Add support for `next/constants`

* minor whitespace fix
2018-10-11 10:47:24 -07:00
Nathan HamblenandAndy aa83866295 @types/pino: recognize changeLevelName field (#29624)
This field has been supported since pino 5.4.0, API
[docs are here][api].

[api]:https://github.com/pinojs/pino/blob/master/docs/api.md#changelevelname-string
2018-10-11 10:46:54 -07:00
Paul SeldenandAndy 1df7a9325c [stellar-sdk]: Fix AccountRecord.data and add data_attr (#29632)
* [stellar-sdk]: Fix AccountRecord.data and data_attr

data is a function to call the /accounts/{id}/data/{key} endpoint, while data_attr is an object bag containing data for the account.

* [stellar-sdk] Add overload to toXDR() which accepts a string encoding
2018-10-11 10:46:24 -07:00
Piotr RoszatyckiandAndy 7325705819 readline-transform: convert to export = (#29560)
* readline-transform: TypeScript Version: 2.7

* readline-transform: convert to `export =`
2018-10-11 10:45:48 -07:00
Piotr RoszatyckiandAndy abb6102c14 replacestream: new typings (#29608)
* replacestream: new typings

* replacestream: fix "Exceeds maximum line length of 200"

* replacestream: use `export =` syntax
2018-10-11 10:44:22 -07:00
Brett MorganandAndy 7fd8a1b5a5 GoogleMaps: Adding aspects to PlaceResult (#29627)
Replaces https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28370
2018-10-11 10:43:05 -07:00
Christian ChownandAndy cc0a868dc1 Add typings for react-native-referrer (#29642) 2018-10-11 10:36:31 -07:00
Christian ChownandAndy d96c3407ae Add typings for react-native-restart (#29644) 2018-10-11 10:36:12 -07:00
Esa-Matti SuuronenandAndy ae7d2e5ef4 elasticsearch: Use Refresh for IndexDocumentParams (#29645) 2018-10-11 10:35:17 -07:00
Esa-Matti SuuronenandAndy 7f7d13a9fb elasticsearch: Narrow exists* return types to boolean (#29643) 2018-10-11 10:35:02 -07:00
Sergey KuznetsovandJohn Reilly c66319d258 Fix conflict with @types/jquery/index.d.ts (#29638)
This [change](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/5e0ae37bedb585846866b6ae8d4db7c97ddc367d#diff-138ae409cf0ed11a88023bb376b56599) causes conflict with  @types/jquery/index.d.ts
2018-10-11 15:50:10 +01:00
Aaron ReismanandAndy ab049f04e7 Add @types/jest-cli (#29558)
* Update index.d.ts

* Update index.d.ts

* make updates from @andy-ms

* Add expectation

* Update types

* Update test

* Lint

* Rename jest-tests.ts to jest-cli-tests.ts
2018-10-10 18:56:22 -07:00
salim7andAndy cd2eb7b120 react-onsenui: Fixed type definitions for Carousel and CarouselItem (#29621)
* react-onsenui: Added missing attributes to existing components and on-change event of a Switch.

* react-onsenui: Fixed typo for ProgressBar intermediate --> indeterminate

* react-onsenui: Fixed type for ProgressBar secondaryValue boolean --> number

* react-onsenui: Fixed type definitions for Carousel and CarouselItem: modifier is optional and itemWidth/itemHeight may be string as well.

* react-onsenui: increased version number
2018-10-10 17:19:48 -07:00
Doug KentandAndy 6ae3761343 [web3]: fix fromWei (#29090)
* fix fromWei

* added tests
2018-10-10 16:56:48 -07:00
lonyeleandAndy 9354cb55e2 Adding types to "storybook-readme" (#29512)
* Creating new package for "storybook_addon-readme"

This is my first time writing a type definition file. There should be something wrong. Please take a look and help me making this better...

* fix name & lint
1. dt-header
--> from "4.0.0-beta1"   to  4.0

2. no-declare-current-package
--> move to the subfolder. Not sure If It works.

3. strict-export-declare-modifiers
--> add "export" to all the type/interface

4. Could not parse version: line is '// TypeScript Version: 3.0.3'
--> Lower to 2.9

* fix npm test
1. Unnecessary "./" at the start of ~~
--> remove "./" part from tsconfig.json

* fix npm test error
1. Error: Expected file 'src/storybook-readme-tests.tsx' to be named storybook-readme-tests.ts
--> change accordingly

* fix npm test eror
1. change name

* fix npm test error
1. change name

* wht src...

* hm...

* path..?

* versino?

* versin

* what..

* versino

* path mapping...

* marked

* move..

* 역시 상위로 가야하나.

* fix npm test
1. Unnecessary "./" at the start of ./src/withReadme.d.ts
--> remove it all

* fix npm test
1. problem with test file at the subfolder
--> Move to the root level

2.  parseDependencyVersionFromPath  error
--> remove paths from tsconfig.json

* add "components/Marked.d.ts"

* fix
1. correct Project url
2. correct Marked to export default (I somehow changed to export during the commits...)

* hm... correct typo

* 1. Write tests with storiesOf from @storybook/react

2. Add "paths" to tsconfig for fixing importing problem of @storybook/readme

3. Fix Errors that has appeared after real test using storiesOf

* Moved all the types to index.d.ts as "andy-ms" suggested

* Remove src/* from tsconfig files as moving all the types to index.d.ts

* Fix "npm lint storybook-readme"
1. I'm just curious why all the types should be exported.
 Isn't it cleaner putting "export" to only actually used types? (such as withDocs, wthReadme, Doc, Marked)
Hm.. or maybe... to be used from actual user?

* Merge upstream Pull from DefinitelyTyped

* fix for andy-ms review
1. Change to overloading with namspace style
2. Avoid intersection type and change to function overloading
3. Change Typescript Version to Minimum version that works

* I tested from 2.3 to upward because of failing npm test with "storybook-readme depends on react but has a lower required TypeScript version."

version 2.8 is the lowest version I could go with. Is It my local setting  that made this problem? I'm not sure...
2018-10-10 16:26:43 -07:00
Andre RochaandJohn Reilly e27e8744f3 Fix react router static router context bug (#29626)
* Fix bug with StaticRouterContext

* Add tests for react-router
2018-10-10 23:40:35 +01:00
Resi RespatiandAndy ca831d1902 [screeps] Release 2.5.1 (#29623) 2018-10-10 14:17:45 -07:00
Ryan CavanaughandGitHub e3cd5fe933 Update CODEOWNERS 2018-10-10 13:55:56 -07:00
Jesse LentzandAndy 9965ee2751 [express-mung] Fix function return types and add write function (#29352)
* [express-mung] Fix function return types and add write function

* [express-mung] Indicate types are for version 0.5.1
2018-10-10 13:14:28 -07:00
Joe FlateauandAndy 731ba7fb8a node-forge: add types for pkcs7 (#29374)
* add types for pkcs7

* bump version number

* revert change of node-forge version number

* mark content/contentInfo as optional and add arg for sign(options?)
2018-10-10 13:13:56 -07:00
Doug KentandAndy 3901652c11 [web3]: improve sendTransaction callback (#29091)
* improve sendTransaction callback

* corrections.  this now just adds tests

* lint
2018-10-10 13:13:30 -07:00
Michal GrňoandAndy e8fd1fd645 [markdown-it] Add typings for extension API (#29436)
* Add typings for extension API

This commit adds types to most of the API that is used when writing a extensions for `markdown-it`. Plus there are some minor improvements.

* fix errors emitted by linter

* increase version of dependencies

* oops, I forgot one

* Add type for StateInline.delimiters
2018-10-10 13:12:52 -07:00
CarlosandAndy 1b0e18e131 [react-imgpro] initial definitions (#28739)
* react-imgpro: initial definitions

* react-imgpro: remove extra rules of tslint.json

* react-imgpro: format
2018-10-10 13:09:43 -07:00
Sean ZhuandAndy e174f81551 [query-string] Make types more accurate (#29395)
* [query-string] Make types more accurate

* Update index.d.ts

* Fix ts errors

* Fix linter errors

* Fix types and make tests more accurate

* Fix linter errors
2018-10-10 13:08:52 -07:00
Filips AlpeandAndy 3052704412 stylelint: add types for creating custom rules (#28076)
* stylelint: add types for creating custom rules

Covers `stylelint.utils` and `stylelint.createPlugin'

* stylelint: use the proper LintResult definition
2018-10-10 13:03:16 -07:00
timtrinidadandAndy acfe3c89c2 @types/jest: relax type definition for toMatchSnapshot (#29371) 2018-10-10 12:58:49 -07:00
tjhsiangandAndy dff15d9443 Make Highcharts Annotation Shape fields optional (#29447) 2018-10-10 12:57:24 -07:00
CiriousJokerandAndy 5e0ae37bed Just added $ to the global exports (#29449) 2018-10-10 12:56:59 -07:00
Neil GentlemanandAndy 7e5f12eec1 [react-bootstrap] fix Dropdown.Menu (#29452)
* [react-bootstrap] remove incorrect exports

several sub-components are exported in index.d.ts, when they are not
in the library itself.

should fail:
`import { DropdownMenu } from 'react-bootstrap';`

should succeed:
`import { Dropdown } from 'react-bootstrap';`
`import DropdownMenu from 'react-bootstrap/lib/DropdownMenu';`

* [react-bootstrap] fix Dropdown.Menu typing

DropdownMenu uses `export =`, so the import must use require, `import *`.

this matches the pattern in Carousel, FormControl, etc.
2018-10-10 12:54:46 -07:00
Elizabeth CraigandAndy 84521a00c5 touch: Add closeAfter option (#29459) 2018-10-10 12:53:58 -07:00
Lucas GarronandAndy 273c8be397 webauthn: Mark rpId and allowCredentials as optional for PublicKeyCredentialRequestOptions. (#29463)
As documented at
https://w3c.github.io/webauthn/#dictdef-publickeycredentialrequestoptions
(already linked in the comment for the interface), the the `rpId` and and
`allowCredentials` fields are optional.
2018-10-10 12:53:43 -07:00
nixxqualityandAndy 3d6ded6cd7 SortFunction signature should match Array.sort (#29468)
-1 and 1 aren't the only numbers allowed. Any number less than or greater than 0 will sort the item properly.
This enables shortcuts like (a, b) => a - b;
Restricting the signature to -1 | 0 | 1 is a mistake.
2018-10-10 12:53:18 -07:00
Justin PowellandAndy 95fdf92cc2 react-modal updates for 3.6 (#29585)
* updates react-modal definitions for 3.6

* adds specs for react-modal definition updates

* adds attribution for react-modal updates

* remove trailing whitespace
2018-10-10 12:52:42 -07:00
Felipe LacerdaandAndy 730cf3a530 [redux-form] Add name to FieldArray.fields (#29598) 2018-10-10 12:52:22 -07:00
Michael FaißtandAndy 6bf0bc358c [@types/leaflet-polylinedecorator] Adjust offset, endOffset and repeat types (#29603)
* offset, endOffset and repeat in the Pattern Interface can also be of type string

* added a few new tests with new string offset, endOffset and repeat
2018-10-10 12:52:06 -07:00
Emily Marigold KlassenandAndy 10ab941fd2 Add types for express-ntlm (#29617) 2018-10-10 12:51:44 -07:00
Igor OleinikovandGitHub 3314940859 Merge pull request #29601 from DJWassink/change/keyframes
[styled-components] Added Keyframes to InterpolationValue
2018-10-10 10:36:13 -07:00
Florian KellerandAndy b1f834289e Add types for express-sitemap-xml (#29576) 2018-10-10 09:39:51 -07:00
Piotr RoszatyckiandAndy f5d631db0b node: setImmediate returns Immediate (#29599)
* node: setImmediate returns Immediate

* node: defined Timer and Immediate internal classes

* node: better compatiblity with Timer interface

* node: return Timeout rather than Timer
2018-10-10 09:38:51 -07:00
Piotr RoszatyckiandAndy 1dcb4dba95 node: console.timeLog (#29600) 2018-10-10 09:28:07 -07:00
Joscha FethandAndy af61ae4b09 jsdom: add ResourceLoader (#29589)
* jsdom: add ResourceLoader

* fix: lints
2018-10-10 09:27:15 -07:00
Piotr RoszatyckiandAndy 19f1f4b082 season: new typings (#29606) 2018-10-10 09:19:02 -07:00
Ivan PankratovandAndy f2d8c72ea3 Add type definitions for getenv (#29607) 2018-10-10 09:16:05 -07:00