Commit Graph
28372 Commits
Author SHA1 Message Date
uglycoyote c0c9cd3d41 Changing Paper.g and Paper.group to return Snap.Paper rather than just Paper (failed Travis test) 2017-03-31 10:18:23 -07:00
uglycoyote 80a1bc1c9f Change return type of Paper.group() and Paper.g() to "Paper"
Prior to this change, the return type of Paper.group() was specified as "any" which was not very helpful.  In my code I was declaring the variable i was storing the group in as "Element" which seemed to make sense at first, but then I later realized that operations like myGroup.line (to add a line in the group) were resulting in type errors.  The "group" type has a line method but the "Element" type does not.

Looking in to the source code a bit more I found that groups are instantiated as Elements but then use the following code (in the Element construcor) to copy methods from the Paper prototype, which I believe makes the group type essentially equal to a "Paper":

```
    if (this.type in {g: 1, mask: 1, pattern: 1, symbol: 1}) {
        for (var method in Paper.prototype) if (Paper.prototype[has](method)) {
            this[method] = Paper.prototype[method];
        }
    }
```

I'm not exactly familiar with this syntax though; it's not clear to me what ```Paper.prototype[has](method)``` exactly means or whether this means that a group object only inherits a subset of the methods from Paper, and therefore there should be some other type in the Type Definition file which corresponds to groups, masks, patterns and symbols.

Perhaps the Paper.mask and Paper.ptrn should be changed to return Paper as well?  I'm not familiar with those so I didn't touch them in the type def file.
2017-03-30 22:40:29 -07:00
Andy f2b6506ba5 Fix various lint errors (#15530) 2017-03-30 17:42:07 -07:00
Nathan Shively-Sanders 51430746a2 Merge pull request #15519 from maxlk/ng-model-options
@types/angular Define debounce option in ng-model-options
2017-03-30 16:02:56 -07:00
Nathan Shively-Sanders bb1433fa5e Merge pull request #15284 from stevehipwell/oauth2orize
Updated oauth2orize typings to include grant and decision
2017-03-30 15:52:21 -07:00
Nathan Shively-Sanders 45a968de32 Merge pull request #15364 from thr0wn/master
angularjs - Fix ITimeoutService interface ($timeout signature)
2017-03-30 15:51:39 -07:00
Nathan Shively-Sanders b6dc00bc4f Merge pull request #15363 from tamird/lodash-topairs
lodash: fix toPairs, toPairsIn definitions
2017-03-30 15:39:09 -07:00
Nathan Shively-Sanders 6477d32c55 Merge pull request #15382 from rzymek/lodash.zipObjectDeep
lodash - Add _.zipObjectDeep
2017-03-30 15:37:49 -07:00
Nathan Shively-Sanders f16a118374 Merge pull request #15409 from ericivarsson/patch-1
Adal - Added optional property navigateToLoginRequestUrl
2017-03-30 15:36:23 -07:00
Andy ff0d451b56 Fix various lint errors (#15529) 2017-03-30 15:33:16 -07:00
Nathan Shively-Sanders b5619e813f Merge pull request #15517 from jmfirth/hyperscript-polymorphism
Improve inference and enable coercion in hyperscript
2017-03-30 15:18:38 -07:00
Justin Firth d7218e2fe3 Support SVG elements; Remove extraneous definition 2017-03-30 18:13:46 -04:00
Nathan Shively-Sanders fc0be958f4 Merge pull request #15516 from maghis/update-stream-buffers
stream-buffers: Correct return type for WritableStreamBuffer.getContents()
2017-03-30 14:37:54 -07:00
Andy 68e0aea47a Lint additional react packages (#15527) 2017-03-30 14:25:38 -07:00
cailenmusselman 389adfc542 findNodeHandle also accepts base react-native components (#15444)
* findNodeHandle also accepts base react-native components

We're also able to pass in base react-native components like View, TextView, etc. to findNodeHandle

* Added static tests for findNodeHandle definition

* Removed trailing whitespace

* Okay NOW all trailing white-space is removed
2017-03-30 14:15:34 -07:00
Andy 6a285d2dcf Lint d3-* packages (#15523) 2017-03-30 14:12:02 -07:00
Andy 3d13ec5399 Lint react-* packages (#15526) 2017-03-30 14:11:46 -07:00
Kalle Ott 4fd2d7547c fixed the semver note in the header comment (#15522)
* fixed the semver note in the header comment

* changed tslint config

* fixed linting
2017-03-30 13:12:51 -07:00
Nathan Shively-Sanders 8f1c970a60 Merge pull request #15507 from jens-duttke/patch-1
requirejs: RequireError.requireModules can be null
2017-03-30 12:47:05 -07:00
Andy 4cac3c5b44 Apply new lint rules in more packages (#15521) 2017-03-30 12:33:22 -07:00
Nathan Shively-Sanders 4173a37d30 Merge pull request #15520 from DefinitelyTyped/make-braintree-umd
Make braintree a UMD module
2017-03-30 12:30:31 -07:00
Nathan Shively-Sanders 7fd19dab3b Move tests into test folder 2017-03-30 12:22:49 -07:00
Nathan Shively-Sanders 78c356783b Merge pull request #15424 from kaoDev/react-virtualized-9.4
React virtualized 9.4
2017-03-30 11:35:07 -07:00
Nathan Shively-Sanders deed8459fa Make braintree a UMD module
Add tests to show that it can be imported as well as used globally.

The change required lots of refactoring. The merged interface-classes
are gone since their constructors were not supposed to be used anyway.
And everything moved into the BraintreeWeb namespace, which was renamed
to just `braintree`.
2017-03-30 11:29:31 -07:00
Justin Firth c0083ec134 Added version commit 2017-03-30 13:03:14 -04:00
maghis d405d11df4 Correct return type for getContents 2017-03-30 12:21:33 -04:00
Nathan Shively-Sanders 729ec22df7 Merge pull request #15490 from giladgray/kss
add kss-node
2017-03-30 08:34:31 -07:00
Jens Duttke 66df4cafa9 requirejs: RequireError.requireModules can be null
In the require.js source code (line 901 in v2.3.3), requireModules is set to `null`.
2017-03-30 09:39:15 +02:00
Gilad Gray 8bd131f9fe enable strictNullChecks 2017-03-29 16:31:05 -07:00
Nathan Shively-Sanders f23f93a55e Merge pull request #15480 from styfle/patch-11
Add `max` length to ParameterOptions
2017-03-29 16:22:59 -07:00
Andy 0dcb154bc0 selenium-webdriver: Apply new lint rules (#15500) 2017-03-29 16:17:11 -07:00
Andy eeb0f2e7eb highcharts: Apply new lint rules (#15502) 2017-03-29 16:16:52 -07:00
Andy 515be0adcf hyco-ws: Apply new lint rules (#15501) 2017-03-29 16:11:11 -07:00
Andy 318b10fd01 jquery.validation: Apply new lint rules (#15497) 2017-03-29 16:02:51 -07:00
Andy 3e861f09ec ignite-ui: Apply new lint rules (#15498) 2017-03-29 16:02:31 -07:00
Andy bd29808df7 react-native: Fix lint failures (#15496)
...mostly by disabling them.
2017-03-29 15:53:09 -07:00
Andy efecc1d637 lodash: Apply new lint rules (#15491) 2017-03-29 15:41:22 -07:00
Andy a38d4c657d fs-promise: Apply new lint rules (#15494) 2017-03-29 15:34:15 -07:00
Andy 3e49f5d2ba angular: Apply new lint rules and remove redundant rules from tslint.json (#15484) 2017-03-29 15:33:53 -07:00
Andy 6e16e2a540 sharepoint: Apply new lint rules (#15492) 2017-03-29 15:24:42 -07:00
Gilad Gray e2be06066b fix linting 2017-03-29 14:57:03 -07:00
Gilad Gray 8d717e1e25 add types for kss 2017-03-29 14:52:20 -07:00
Andy 1aff76c069 vinyl-fs: Lint (#15489) 2017-03-29 14:50:51 -07:00
Andy d426ff3083 Apply new lint rules to yet more packages (#15486) 2017-03-29 14:46:16 -07:00
Andy 2628148cfc amplify: Apply new lint rules (#15483) 2017-03-29 14:25:29 -07:00
Andy 5f3ba45136 Use dtslint (#15482) 2017-03-29 13:07:39 -07:00
Nathan Shively-Sanders cf1a611252 Merge pull request #15477 from praxxis/linkify-it
Add types for linkify-it
2017-03-29 12:54:16 -07:00
Nathan Shively-Sanders f30d96240f Merge pull request #15475 from stephenlautier/feature/multimatch
added definitions for multimatch
2017-03-29 12:35:14 -07:00
Steven 57c79ade9f Add max length to ParameterOptions 2017-03-29 14:58:56 -04:00
Andy 77649ca319 leaflet.locatecontrol: Remove useless package.json (#15479) 2017-03-29 11:33:18 -07:00