* Fix callback types
These were half-fixed recently (in my local version `err` cannot be `undefined`). But if you check the code the second parameter to all the callbacks should be `| undefined` too. I haven't checked all these callbacks exhaustively.
I also changed the SFTP callbacks from `any` to `Error | undefined`. Again I haven't fully analysed the entire code but it seems likely that this is the correc type.
Also changed some fields to use `?` which is a bit more idiomatic, and fixed the type of the `getConnections` callback (according to the Node typings - who knows if those are correct?).
* Missed one parameter
* Fix the typing of Callback.
The previous typing for `Callback` makes no sense. If someone used a callback that had both attributes (which is the most common case), then `err` would be typed as
`undefined` inside the callback. However, whether or not `err` is undefined is not determined by the number of
parameters set on the callback. The previous typing would have been correct if there was a guaranteed that when the
callback has two parameters, the first one is necessarily `undefined`. But there is no such guarantee. If an error
happened, then the first parameter is **not** undefined.
* Fix the return values of inputField.
The Promise was declared to resolve to `boolean` which is absolutely incorrect. `inputField`'s promise resolves to a
string. If cancelation was allowed the user canceled (hit escape), then the final value may be undefined this is true both for the promise and the callback.
* Make the promise mandatory on the return value of inputField.
The promise on the object returned by inputField is always present.
* Fix the return value of inputField to always return a value.
inputField *always* returns an object, *irrespective* of whether a callback is passed. The object is more complex than
currently defined but I only use the `promise` field on it and have no inclination to figure the whole object's
structure. Someone else will have to figure it out.
* Drop the explicit typings on the callback parameters.
They override, and consequently they obscure, the typings that are provided by the definition files.
* Test that abort field is present on return value of inputField.
terminal-kit *always* provides it, callback or no callback.
* The new typings make input be possibly undefined.
The current `CompletionCallback` type doesn't allow you to set `error: null`, which is required if you don't have an actual error. This change allows for that
* [chess.js] add new method
* [chess.js] correct method name in test
* [chess.js] correct test case
* [chess.js] run prettier
* [chess.js] ts lint
* [chess.js] update package version
* Revert "[chess.js] update package version"
This reverts commit aeea50bc67ee9f9353507f07a99b2bd60488d737.
Co-authored-by: Zachary Svoboda <svobodaz@orvis.com>
* refactor(gestalt): updated gestlat to newest types
gestalt updated to now version v1.10.0
BREAKING CHANGE: Box, Mask, Touchable
* added tests
* removed licence
* array error
* Array<> error
* array<> error fixed
* void type error after test fixed
* error on masonry fixed
* feat(gestalt): updated to as of version v1.11.1
* feat(gestalt ): updated to as of v1.11.1
* updated version nmbr added name to definitions by
* removed name from definition by
* patch version error on test fixed
* updated to v1.15.0
* added dictionary {size -> ImageData} option to imageData property
* exposed concealed ClassValue type in classnames package
* corrections per tslint
* moved additional types into namespace
* added SameSiteStatus to chrome.cookies
* synced up classnames
* fixed newline
* made sameSite optional in SetDetails
* added @since Chrome 51. moniker to sameSite
* added sameSite to cookies in sinon-chrome package
Tim