* Add PolyhedronBufferGeometry and subclasses
Added PolyhedronBufferGeometry and the four BufferGeometries subclassing it (TetrahedronBufferGeometry, OctahedronBufferGeometry, DodecahedronBufferGeometry, and IcosahedronBufferGeometry).
* Fix constructors for PolyhedronGeometry subclasses
The PolyhedronGeometry subclasses all have optional parameters for their constructor, but not all the type definitions were in line on this.
* [@types/rpio] Fix poll parameter to accept null
As written in the `poll` function documentation the `cb` parameter should accept null as a value.
* Update rpio-tests.ts
* Add myself as contributor
* Added correct flag type to Interface.release() in usb package
* Update Interface.release() to outline both ways of calling it
* Added missing fields, fixed the bMaxPacketSize0 field name and highlighted the params are optional in InEndpoint.startPoll()
* Add undocumented descriptor fields
* fix(types): add col to CountOptions and FindOptions interface
Added missing property 'col' in CountOptions and FindOptions interface.
* Added missing property 'col' in CountOptions and FindOptions interface in v3
* added testcase
* remove col attribute from FindOptions
* Removed whitespaces
* Ember Feature Flags: use interface to support merging user-defined props.
* Fix test file name.
* Inline (in-file?) `assertType` for ember-feature-flags.
I had two PRs merge close together that caused the build to fail.
- #22809 fixed a bug
- #22821 removed all the overrides from `tslint.json`
Unfortunately, the former ended up with a couple lint issues.
```
./types/request/index.d.ts
ERROR: 64:20 unified-signatures This overload and the one on line 63
can be combined into one signature taking `string | RequiredUriUrl &
TOptions`.
./types/request/request-tests.ts
ERROR: 10:5 prefer-const Identifier 'value' is never
reassigned; use 'const' instead of 'let'.
```
Please fill in this template.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).
- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).
- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).
Select one of these and delete the others:
If changing an existing definition:
- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/facebook/react-native/blob/master/Libraries/Modal/Modal.js#L161
Additional info:
Just like the onShow optional prop, the Modal's onOrientationChange prop can capture a NativeSyntheticEvent at the time of the hardware change. This allows the developer to determine if the orientation change was to the landscape or portrait style and react accordingly.