mirror of
https://github.com/gosticks/DefinitelyTyped.git
synced 2026-10-06 07:47:04 +00:00
Dani H
7238786d4d
When passing data to a d3 structure the data can be very flexible. The current interface of the GraphNode requires many data attributes to be present, most of which aren't required to draw the visualization. In fact, d3 calculates some of them itself, so passing them to the GraphNode would be redundant. In this example http://bl.ocks.org/mbostock/4063269#flare.json, Mike Bostock uses the attribute className to identify name and packageName to identify color in the GraphNode. This means that he doesn't only ignore all of the attributes DefintelyTyped provides, but comes up with his own attributes. This means that the data passed in could in fact be a hashmap/js object type with arbitrary attributes. It's only when the data is used with d3 methods to identify what attribute represents size/color etc... that the type becomes relevant. So either the GraphNode should be less restrictive (or in fact an arbitrary hashmap) or I've misunderstood some core concept. You don't have to necessarily merge this pull request, if I'm right some parts will have to be rewritten (GraphNodes seem to be used everywhere), but hopefully it might spark some discussion.
DefinitelyTyped 
The repository for high quality TypeScript type definitions.
For more information see the definitelytyped.org website.
Usage
Include a line like this:
/// <reference path="jquery.d.ts" />
Contributions
DefinitelyTyped only works because of contributions by users like you!
Please see the contribution guide on how to contribute to DefinitelyTyped.
How to get the definitions
- Directly from the Github repos
- NuGet packages
- TypeScript Definition manager
List of definitions
- See CONTRIBUTORS.md
Requested definitions
Here is are the currently requested definitions.
Licence
This project is licensed under the MIT license.
Copyrights on the definition files are respective of each contributor listed at the beginning of each definition file.