With the two previous commits we can now safely remove the `restacked` signal
watching. For some reason watching the signal is this way blocks clicks while things are
moving.
So now it's possible to eg. doubleclick on the left/right edge and jump
two places.
This is no longer necessary as we now raise windows when we know if they will be
visible after animation, which is much better than after animation is finished.
When we propagate the position forward/backward we check the desired position
against the left/right limits and stack the rest of the windows if it's the
case.
This also fixes the stack performance issue in a cleaner way. We simply raise
all non-stacked windows while propagating, instead of doing a fix-up afterwards.
When navigating workspaces in mru order animating the workspaces based on the
mru order gives a false sense of spatiallity. Instead simply animate the
previewed workspace from the bottom and animate the last workspace down.
`selectedWindow` isn't necessarily a visible window, eg. when we're doing
previews, so just do a search from the start/end up until we find the last
stackd window.
The bottleneck when calling ensure seems to be calling lower on every window on
the left/right stack.
This is a quick fix, where we simply call raise on the top of the left/right
stack, and the visible windows.
A consequence of this change is the left/right stacks might be above a visible
window for a short time, but it's not very noticeable.
When there's only workspaces on the primary display, moving a window to another
monitor makes it `stick`. In the past this would make it part of the scratch
layer, but that's not the case anymore, so it would just be detached and
attached to the workspace again.
This makes it possible to simply drag a window from a space into another monitor
and it will detach and float on the monitor.
This makes it possible, with some work, to use a combination of above and
minimized to detect scratch windows. Leaving always visible on all workspaces
functional for multimonitor use.
As mentioned we need to use a combination of above and minimized since minimized
windows can't be above.
Restoration require the same settings object to be available due to the use of
Map. Indexing on the canonical name of the schema is probably a better solution.
add_all_from_workspace needs the same logic as add_handler, so move it to the
common add_filter.
This fixes a regression from the last commit which caused scratch windows to
inserted in a space when restarting Gnome Shell.
Windows on the stack should never be on top, windows not on the stack will never
overlap. Which means that alaways on top is never wanted for ordered windows.
The issue is noticed when attaching a scratch window to the page strip, as it
will continue to be always on top, making the stack overlap visible windows.
Since we're using mru order on the workspaces it's cleaner to just use our own
actions. In addition this might make it easier to handle enable/disable by
blanking the bindings on disable (not sure if it's possible to set the bindings
without touching dconf/gsettings though).
Schema change, so require recompilation.
Tor Hedin Brønner