Commit Graph

304 Commits

Author SHA1 Message Date
Arnon Keereena
3b04a2b94a Add comment 2017-04-27 08:29:03 +02:00
Arnon Keereena
9eb91a8605 Add tests for modified code.
Fix some errors.
2017-04-27 08:26:34 +02:00
Arnon Keereena
18ee34f681 Fix per comment
- Move allCommits to Repository class
- Remove unwanted spaces
- Restore --lenient flag, even though it still produce compile error
2017-04-27 07:56:56 +02:00
Arnon Keereena
43d26912a1 Update Quick, Result & ZipArchive 2017-04-25 21:17:33 +02:00
Arnon Keereena
0785b70123 Merge develop into master 2017-04-25 20:53:21 +02:00
Arnon Keereena
20365249f9 Add ability to get all commits from a branch 2017-04-25 20:52:59 +02:00
Matt Rubin
9a2f5a5b31 Merge pull request #88 from mattrubin/lower-case-enum-cases
Convert enum case names to lower camel case
2017-04-24 14:13:34 -04:00
Matt Rubin
3c5ffa2ba5 Re-enable the identifier_name SwiftLint rule 2017-04-24 12:52:30 -04:00
Matt Rubin
6257318a34 Merge origin/master into lower-case-enum-cases 2017-04-24 12:50:33 -04:00
Matt Rubin
f2d94c4322 Merge pull request #86 from mattrubin/swiftlint
Improvements for SwiftLint 0.18
2017-04-24 12:49:51 -04:00
Matt Rubin
d1d0118bba Remove the empty associated value on Credentials.default
The empty payload is unnecessary, and it will be removed in a future version of Swift:
https://github.com/apple/swift-evolution/blob/master/proposals/0155-normalize-enum-case-representation.md#alternative-payload-less-case-declaration
2017-04-24 11:48:06 -04:00
Matt Rubin
c57ea50b85 Use the Xcode 8.3 Travis image, which has SwiftLint 0.18.1 installed
https://blog.travis-ci.com/2017-04-19-xcode-832-is-here
2017-04-24 11:24:46 -04:00
Matt Rubin
5b41c977d2 Convert enum case names to lower camel case
https://swift.org/documentation/api-design-guidelines/#follow-case-conventions
2017-04-24 00:19:27 -04:00
Matt Rubin
4cadad501e Disable Swiftlint identifier_name rule, and enable several other rules 2017-04-23 23:54:16 -04:00
Matt Rubin
bb387eb7ab SwiftLint: Returning Void in a function declaration is redundant 2017-04-23 23:25:36 -04:00
Matt Rubin
f10c8d03dd Run the SwiftLint build phase with the --lenient flag
Running SwiftLint in "lenient" mode will only generate warnings, preventing the linter from causing the build to fail.
https://github.com/realm/SwiftLint/issues/1322
2017-04-23 23:24:53 -04:00
Matt Rubin
b074eff7d7 Merge pull request #83 from SwiftGit2/release-badge
Fix the release badge in the README
2017-01-07 17:56:49 -05:00
Matt Rubin
e42270372c Fix the release badge in the README 2017-01-07 16:41:39 -05:00
Matt Diephouse
4864cc4753 Merge pull request #82 from SwiftGit2/swift3-readme
Update README.md for Swift 3
2017-01-07 14:44:46 -05:00
Matt Diephouse
2e7a0ce1cd Update README.md 2017-01-07 14:44:28 -05:00
Matt Diephouse
36f934d2b6 Merge pull request #78 from mattrubin/guard
Use guard-else instead of if statements when checking git error codes
2016-12-24 01:48:44 -05:00
Matt Rubin
98c0733592 Merge pull request #79 from mattrubin/swiftlint
Update lint configuration for Swiftlint 0.15
2016-12-23 23:56:03 -05:00
Matt Rubin
992ba7bf8a Merge master into guard 2016-12-23 23:51:14 -05:00
Matt Rubin
545bf12645 Merge pull request #77 from mattrubin/whitespace
Remove trailing whitespace on blank lines
2016-12-23 18:25:25 -05:00
Matt Rubin
62619af5e8 Clean up some whitespace around = operators 2016-12-23 18:09:56 -05:00
Matt Rubin
4741790d2c Wrap lines longer than 120 characters 2016-12-23 18:01:28 -05:00
Matt Rubin
e148cd2530 Enable new opt-in SwiftLint rules 2016-12-23 18:01:28 -05:00
Matt Rubin
baeb5cb3e2 Ignore unused closure parameters 2016-12-23 18:01:28 -05:00
Matt Rubin
28c01d4943 Use guard-else instead of if statements when checking git error codes
The compiler will warn if a guard statement falls through without exiting the scope.
2016-12-23 17:57:35 -05:00
Matt Rubin
a0f0e49ee6 Remove trailing whitespace on newlines 2016-12-23 17:48:54 -05:00
Matt Diephouse
2cc5737d77 Merge pull request #72 from mattrubin/swift-api-guidelines
Swift API design guidelines
2016-12-23 17:38:18 -05:00
Matt Rubin
c746c720c3 Remove the OID argument label for object getters 2016-12-22 23:36:25 -05:00
Matt Rubin
6da9e7810c Argument labels "withName:" -> "named:" 2016-12-22 18:36:58 -05:00
Matt Rubin
597a2fd000 Rename mapGit* methods back to withGit* 2016-12-21 23:37:21 -05:00
Matt Rubin
9c13bee3ad Delete unavailable method stubs 2016-12-19 00:21:24 -05:00
Matt Rubin
a4e26a4b99 Apply API guidelines to private Repository helper functions 2016-12-19 00:17:33 -05:00
Matt Rubin
b94b975236 Fix method description strings in RepositorySpec 2016-12-18 23:24:57 -05:00
Matt Rubin
afbd6672cd Rename argument labels to refer to OID parameters as "Identifiers"
https://swift.org/documentation/api-design-guidelines/#name-according-to-roles
2016-12-18 23:24:26 -05:00
Matt Rubin
ca028a4e4f Convert parameter and property names to camel case, per API guidelines 2016-12-18 22:40:47 -05:00
Matt Rubin
21ee7a44c5 Convert test helper free functions to private extension methods 2016-12-18 22:28:00 -05:00
Matt Rubin
93ddcd3e9a Apply API guidelines to test helper functions 2016-12-18 18:11:04 -05:00
Matt Rubin
2a90c7b5f3 Update Repository methods to match the API design guidelines 2016-12-18 18:11:04 -05:00
Matt Rubin
94c7de848f Convert libGit2Error free function to an NSError convenience initializer 2016-12-18 18:11:04 -05:00
Matt Rubin
3c3c3ff004 Improve argument parameters on git_strarray extension methods
Omit the external argument label and give parameters clearer names.
2016-12-18 18:11:04 -05:00
Matt Diephouse
561b0453c5 Merge pull request #71 from mattrubin/swiftlint
Configure SwiftLint
2016-12-18 14:50:47 -05:00
Matt Rubin
b660b09c7a Add a target which just runs SwiftLint, and add it to both schemes 2016-12-18 14:04:25 -05:00
Matt Rubin
31d3412310 Configure SwiftLint's trailing whitespace warnings to ignore empty lines 2016-12-18 00:40:34 -05:00
Matt Rubin
c8ce857e42 Lint: Multi-line collection literals should include trailing commas 2016-12-18 00:37:50 -05:00
Matt Rubin
416dbaa08f Lint: Limit vertical whitespace to a single empty line 2016-12-18 00:33:26 -05:00
Matt Rubin
3da641e708 Lint: Lines should not have trailing semicolons 2016-12-18 00:32:15 -05:00