Commit Graph

268 Commits

Author SHA1 Message Date
Matt Rubin
b94b975236 Fix method description strings in RepositorySpec 2016-12-18 23:24:57 -05:00
Matt Rubin
afbd6672cd Rename argument labels to refer to OID parameters as "Identifiers"
https://swift.org/documentation/api-design-guidelines/#name-according-to-roles
2016-12-18 23:24:26 -05:00
Matt Rubin
ca028a4e4f Convert parameter and property names to camel case, per API guidelines 2016-12-18 22:40:47 -05:00
Matt Rubin
21ee7a44c5 Convert test helper free functions to private extension methods 2016-12-18 22:28:00 -05:00
Matt Rubin
93ddcd3e9a Apply API guidelines to test helper functions 2016-12-18 18:11:04 -05:00
Matt Rubin
2a90c7b5f3 Update Repository methods to match the API design guidelines 2016-12-18 18:11:04 -05:00
Matt Rubin
94c7de848f Convert libGit2Error free function to an NSError convenience initializer 2016-12-18 18:11:04 -05:00
Matt Rubin
3c3c3ff004 Improve argument parameters on git_strarray extension methods
Omit the external argument label and give parameters clearer names.
2016-12-18 18:11:04 -05:00
Matt Diephouse
561b0453c5 Merge pull request #71 from mattrubin/swiftlint
Configure SwiftLint
2016-12-18 14:50:47 -05:00
Matt Rubin
b660b09c7a Add a target which just runs SwiftLint, and add it to both schemes 2016-12-18 14:04:25 -05:00
Matt Rubin
31d3412310 Configure SwiftLint's trailing whitespace warnings to ignore empty lines 2016-12-18 00:40:34 -05:00
Matt Rubin
c8ce857e42 Lint: Multi-line collection literals should include trailing commas 2016-12-18 00:37:50 -05:00
Matt Rubin
416dbaa08f Lint: Limit vertical whitespace to a single empty line 2016-12-18 00:33:26 -05:00
Matt Rubin
3da641e708 Lint: Lines should not have trailing semicolons 2016-12-18 00:32:15 -05:00
Matt Rubin
3150d56e28 Lint: Files should have a single trailing newline 2016-12-18 00:30:11 -05:00
Matt Rubin
0f29b097e1 Lint: if statements shouldn't wrap their conditionals in parentheses 2016-12-18 00:28:51 -05:00
Matt Rubin
66cf46d67d Lint: Colons should be next to the identifier when specifying a type 2016-12-18 00:26:56 -05:00
Matt Rubin
686a41fbb7 Add a basic SwiftLint configuration 2016-12-18 00:25:30 -05:00
Matt Diephouse
8692c46a0c Merge pull request #70 from mattrubin/swift-3
Swift 3
2016-12-17 21:08:56 -05:00
Matt Rubin
7b52e822ce Simplify path mapping in the Repository initializer 2016-12-17 02:06:47 -05:00
Matt Rubin
1fb378dbaf Use the Swift API for getting a URL's file system representation 2016-12-17 01:46:55 -05:00
Matt Rubin
160428039e Use optional binding instead of comparing to nil and force-unwrapping 2016-12-17 01:33:36 -05:00
Matt Rubin
6244bdfdc6 Avoid using a double pointer with git_branch_name 2016-12-17 01:16:17 -05:00
Matt Rubin
755dfe08f6 Use non-Optional pointers wherever possible 2016-12-17 00:37:50 -05:00
Matt Rubin
003464dde8 Replace NSTimeZone with TimeZone 2016-12-17 00:36:00 -05:00
Matt Rubin
b6c3c795bc Replace NSDate with Date wherever possible 2016-12-17 00:35:55 -05:00
Matt Rubin
59cccf62d0 Replace NSURL with URL wherever possible 2016-12-17 00:35:44 -05:00
Matt Rubin
f97fcfab38 Convert source and tests to build with Swift 3 2016-12-17 00:22:08 -05:00
Matt Rubin
485b637d47 Update dependencies to support Swift 3 2016-12-17 00:16:24 -05:00
Matt Diephouse
0218aa1123 Merge pull request #69 from mattrubin/xcode-8.2
Xcode 8.2
2016-12-16 14:42:19 -05:00
Matt Rubin
9bae55743b Create a new simulator device to avoid xcodebuild exit status 70
The Travis CI Xcode 8.2 image has two simulator devices for each device type for the latest iOS.
The previous destination specifier caused xcodebuild to fail with exit status 70 and the error message:
"The requested device could not be found because multiple devices matched the request."
2016-12-16 13:22:17 -05:00
Matt Rubin
4198f090fe Configure Travis to build with Xcode 8.2 2016-12-16 12:13:11 -05:00
Matt Diephouse
de0cee0806 Merge pull request #68 from mattrubin/build-settings
Clean up build settings
2016-12-15 19:46:36 -05:00
Matt Rubin
869fb17c8b Clean up static library build settings (and the names of the products)
The static library dependencies are built by external scripts, and do not use the naming settings specified here. However, Xcode uses the PRODUCT_NAME setting to generate the name of the placeholder product reference it creates automatically for each target.Specifying the base names of each static library in the build settings causes Xcode to generate names for its placeholder products which match the products that are actually built by the scripts.
2016-12-15 18:25:04 -05:00
Matt Rubin
fe97151d16 Use the correct Info.plist for the iOS test target 2016-12-15 18:01:56 -05:00
Matt Rubin
d38954516a Enable bitcode for the iOS framework
Bitcode is already enabled for the static library dependencies.
2016-12-15 17:58:56 -05:00
Matt Rubin
2289706481 Remove unnecessary SUPPORTED_PLATFORMS and VALID_ARCHS build settings 2016-12-15 17:48:07 -05:00
Matt Rubin
c151e05911 Remove extraneous install name and install path build settings 2016-12-15 17:46:16 -05:00
Matt Rubin
dc8a391290 Clean up search path build settings 2016-12-15 17:38:33 -05:00
Matt Rubin
717abc1cb3 Remove unnecessary or overridden project build settings 2016-12-15 17:14:11 -05:00
Matt Rubin
ae34822fab Delete unused versioning build settings 2016-12-15 17:09:36 -05:00
Matt Rubin
236712b9d3 Set xcconfigs for static libraries and remove duplicated build settings 2016-12-15 17:06:37 -05:00
Matt Rubin
c4c40f5173 Delete target build settings which duplicate settings from the xcconfigs 2016-12-15 17:01:14 -05:00
Matt Rubin
eee3ca4446 Delete project build settings which duplicate settings from the xcconfig 2016-12-15 16:57:57 -05:00
Matt Rubin
7ffe3bbb3b Remove FRAMEWORK_SEARCH_PATHS from test targets
These extra search paths were unnecessary and causing warnings from the linker.
2016-12-15 16:24:21 -05:00
Matt Diephouse
a8d16010ff Merge pull request #67 from mattrubin/modulemap
Use a modulemap for libgit2
2016-12-14 11:46:15 -05:00
Matt Rubin
d1b72d059d Add export and inferred submodule declarations to the libgit2 modulemap 2016-12-13 23:31:31 -05:00
Matt Rubin
a4072adf1e Remove libgit2 group and modulemap file reference from the Xcode project 2016-12-13 05:24:48 -05:00
Matt Rubin
d4e2413e50 Update the libgit2 modulemap to avoid "does not include header" warnings
Also, use symlinks to enable cleaner path strings in the modulemap.
2016-12-13 05:15:47 -05:00
Matt Rubin
c2535ace3f Add a libgit2 modulemap and remove the libgit2 headers from SwiftGit2 2016-12-13 04:27:38 -05:00