mirror of
https://github.com/gosticks/brew.git
synced 2026-10-04 06:26:59 +00:00
audit: prefer https/s over ftp where known available
The FTP protocol is prone to getting firewalled to death in places, so where we know we can avoid that by using either secure or more commonly accepted protocols let's do so. Examples of output: ``` * Stable: ftp://ftp.cpan.org/pub/CPAN/authors/id/N/NE/NEILB/Time-Duration-1.20.tar.gz should be `http://search.cpan.org/CPAN/authors/id/N/NE/NEILB/Time-Duration-1.20.tar.gz` * Stable: Please use https:// for ftp://ftp.mirrorservice.org/sites/lsof.itap.purdue.edu/pub/tools/unix/lsof/lsof_4.89.tar.bz2 ```
This commit is contained in:
@@ -1175,6 +1175,16 @@ class ResourceAuditor
|
||||
end
|
||||
end
|
||||
|
||||
# Prefer HTTP/S when possible over FTP protocol due to possible firewalls.
|
||||
urls.each do |p|
|
||||
case p
|
||||
when %r{^ftp://ftp\.mirrorservice\.org}
|
||||
problem "Please use https:// for #{p}"
|
||||
when %r{^ftp://ftp\.cpan\.org/pub/CPAN(.*)}i
|
||||
problem "#{p} should be `http://search.cpan.org/CPAN#{$1}`"
|
||||
end
|
||||
end
|
||||
|
||||
# Check SourceForge urls
|
||||
urls.each do |p|
|
||||
# Skip if the URL looks like a SVN repo
|
||||
|
||||
Reference in New Issue
Block a user