Commit Graph
8971 Commits
Author SHA1 Message Date
Zhiming Wang 18b20c9eaf synfigstudio: boneyard
Main reasons for boneyard:

* As this formula now stands, it fails to build (with a mysterious
  error) against FFmpeg 3.0 (#49178);

* This is a GUI-only tool (look at its awkward test), so it doesn't
  quite belong to core to begin with; and due to the build issue above,
  work is needed if it is to be revived in homebrew/gui;

* There's not enough interest, seeing that we are two releases or half a
  year behind, and no user even proposed a version bump;

* Upstream's preferred method of installation is the app bundle (which
  seems to be a much more complete solution, given the app bundle's
  size), distributed in binary disk images.

More discussions in Homebrew/homebrew#49178.

Closes Homebrew/homebrew#49378.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-02-21 04:24:34 +00:00
Dominyk Tiller e00375e381 test_pathname: add append_lines tests
Closes Homebrew/homebrew#49233.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-02-21 04:22:23 +00:00
Dominyk Tiller ff4d16deeb pathname: add append_lines method
* Blocks writing of new files via accidental typos, etc, which the normal open("blah", "a") doesn't.
* Where files don't exist they should ideally be using `(buildpath/"dog").write` instead of open("blah", "a") already.
* It's a bit less cluttered looking if you need several writes to different files in the formula, IMO.
2016-02-21 04:22:23 +00:00
Xu Cheng 7c9dff1f1e plist_caveats: ensure it ending with newline
Closes Homebrew/homebrew#49374.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-02-21 12:15:31 +08:00
Dominyk Tiller bfbdfe8d9d env/shared: ignore perl opts
In theory, letting these be set once wasn't an awful idea because it allows
users choice on where Perl modules end up.

In reality, as we've moved closer to sandboxing and at the same time accepted more
perl binding options into formulae it has been exposed as something of a hellraiser.

It's not that uncommon for Perl users to set a custom `INSTALL_BASE` in the ENV which
means we end up with quite a few formula that fail hard with this sort of error:

```
Only one of PREFIX or INSTALL_BASE can be given. Not both.
```

The other common error, which we discovered via sandboxing, is that the Perl modules
end up outside Homebrew's control which means we don't automatically remove them
when the package is removed. Sandboxing blocks this, which means when we eventually
move to enable that by default for users as well as CI it'll quickly become a
prominent issue.
2016-02-20 19:30:31 +00:00
Dominyk Tiller 7572e91a60 diagnostic: add new osxfuse exceptions
The recent updates to OSXFuse include two new elements that get flagged by
`brew doctor`. Adding them here so it's consistent with how we handle the rest
of OSXFuse.

Closes Homebrew/homebrew#49372.
2016-02-20 19:24:30 +00:00
Alex Dunn f15532452e version: correctly parse codeload URLs
Needed for Homebrew/homebrew#49346.

Closes Homebrew/homebrew#49354.

Signed-off-by: Alex Dunn <dunn.alex@gmail.com>
2016-02-19 17:36:42 -08:00
Dominyk Tiller b54d477416 PULL_REQUEST_TEMPLATE: tweaks
Closes Homebrew/homebrew#49353.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-02-19 23:14:10 +00:00
Dominyk Tiller a688dc2c8c ISSUE_TEMPLATE: tweaks 2016-02-19 23:14:10 +00:00
Zhiming Wang 6f952779c8 phash: boneyard
Boneyarding because:

1. Not compatible with FFmpeg 3.0 (#49178);
2. Not developed in the open, only release tarballs are available, so
   tracking progress is hard;
3. Latest release is from April 2013;
4. Has to join a mailing list to report bugs, the archive of which was
   last built in 2014.

In summary, there's no evidence that this library is not abandoned.

See also discussions in Homebrew/homebrew#49178.

Closes Homebrew/homebrew#49268.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-02-19 23:04:51 +00:00
Xu Cheng cfc5fed7ce update: fix fork bomb caused by brew update --help
Fixes Homebrew/homebrew#49334.

Closes Homebrew/homebrew#49343.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-02-19 17:28:37 +08:00
Misty De Meo d431f20d88 brew: print help when no commands given
Fixes Homebrew/homebrew#49325.

Closes Homebrew/homebrew#49327.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-02-19 09:04:22 +00:00
Martin Afanasjew f8a86e5962 tests: add groups and project name to coverage
Groups make it easier to get an overview of the coverage without having
to scan through a single very long list of files. They also display a
possibly helpful per-group coverage.

The project name is normally derived from the `root` directory which
happens to be `Library` in our case, thus make it explicitly `Homebrew`.

Closes Homebrew/homebrew#49303.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2016-02-18 21:54:14 +01:00
Martin Afanasjew 5aa2712694 docs: fix URLs in issue/PR template
Sadly, relative URLs don't work in this context.
2016-02-18 14:40:07 +01:00
Martin Afanasjew c41d58979f docs: fix minor language/style inconsistencies
Always leave a blank line between headings and the following checklists.
2016-02-18 14:33:35 +01:00
ilovezfs 8e6c3ab039 update: always checkout master.
This should help to prevent situations where a user accidentally ends up
"stranded" in a branch indefinitely.

Additionally, the stash is never popped automatically at the end of a
successful update, but the stash-pop message is printed if something is
stashed.

When an interrupt occurs, the original behavior is still in place
(switch back to the old branch and revision, and pop the stash), though
this could be changed as well.

This commit modifies the behavior of both `brew update` and
"update-bash.sh" in the manner described above.

The idea for this approach is from Mike McQuaid.

Issue Homebrew/homebrew#48812

Closes Homebrew/homebrew#48993.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-02-18 10:44:14 +00:00
Mike McQuaid 3ac1c7b653 update: use GitHub API to avoid unneeded fetches.
Check to see if `HEAD` is the same as what we have locally. If it is:
don't bother to `git fetch`.

Closes Homebrew/homebrew#47888.

Closes Homebrew/homebrew#49219.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-02-18 10:43:10 +00:00
Mike McQuaid f2faf49e3f formula_installer: use new pour_bottle DSL. 2016-02-18 10:21:20 +00:00
Mike McQuaid c5ec986c72 formula_installer: improve bottle cellar message. 2016-02-18 10:21:20 +00:00
Mike McQuaid e62dc13252 formula_installer: cleanup existing pour_bottle logic. 2016-02-18 10:21:20 +00:00
Mike McQuaid 26ec9f9ea0 formula: add new pour_bottle DSL with reason.
This allows there to be a user-visible description of why a bottle is
not being installed.
2016-02-18 10:21:20 +00:00
Mike McQuaid 74858b28c5 software_spec: add new bottle check class. 2016-02-18 10:21:20 +00:00
David Caldwell bff90a7233 brew: Make HOMEBREW_REPOSITORY different from prefix only when 'brew' is a symlink
Closes Homebrew/homebrew#49261.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-02-18 09:32:46 +00:00
David Caldwell 94034a6915 brew: Make HOMEBREW_LIBRARY based off of HOMEBREW_REPOSITORY
This makes the logic match the Ruby code from before it was moved here
(see 390e327f55126f7ee9519bc6c03a0c0aa14f7168)
2016-02-18 09:32:46 +00:00
David Caldwell 9e32aede10 brew: Don't re-canonicalize
HOMEBREW_BREW_FILE and BREW_FILE_DIRECTORY are already canonicalized.
2016-02-18 09:32:46 +00:00
Mike McQuaid 8156e76576 Move Kickstarter supporters file. 2016-02-18 08:21:20 +00:00
Dominyk Tiller 3b0e89c43d FAQ: minor tweaks
Closes Homebrew/homebrew#49281.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-02-18 08:19:17 +00:00
Dominyk Tiller 81c97e1686 PULL_REQUEST_TEMPLATE: create initial template 2016-02-18 08:19:17 +00:00
Dominyk Tiller a049aaa84c docs: move security reporting guidelines 2016-02-18 08:19:17 +00:00
Dominyk Tiller bcc5591702 ISSUE_TEMPLATE: create initial template
Closes Homebrew/homebrew#41321.
2016-02-18 08:19:17 +00:00
Dominyk Tiller 6e33ace71b Formula-Cookbook: update CONTRIBUTING path 2016-02-18 08:19:17 +00:00
Dominyk Tiller e9a9c8a73b doc/homebrew/FAQ: update CONTRIBUTING path 2016-02-18 08:19:17 +00:00
Dominyk Tiller be79583b4e doc/homebrew/README: update CONTRIBUTING path 2016-02-18 08:19:17 +00:00
Dominyk Tiller eae1fe9eea CONTRIBUTING: move to /.github 2016-02-18 08:19:17 +00:00
Dominyk Tiller ee9b657213 gitignore: update documentation paths 2016-02-18 08:19:17 +00:00
Dominyk Tiller 4a289a65d4 Troubleshooting: remove dead link 2016-02-18 05:07:25 +00:00
Dominyk Tiller 9b2765c04f El_Capitan_and_Homebrew: remove document
We haven't seen this for a fair while since Apple pushed further updates to the
SIP mechanism and believe it to be far less of an issue than it was previously.

If you encounter further failure, please file an Issue and we'll be happy to
help! At the moment though this advice is making people think there _will_ be an
issue at some point, which isn't generally proving the case.
2016-02-17 18:55:41 +00:00
Baptiste Fontaine 4c5aee7a56 version: fix GitHub releases URLs parsing
The current code doesn't work with releases that have more than one
digit in the third group, i.e.:

  .../releases/download/1.2.3/...  works
  .../releases/download/1.2.34/... doesn't work

Closes Homebrew/homebrew#49255.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2016-02-17 13:23:26 +01:00
Brandon Ooi 270f601050 blackbox 1.20160122
Closes Homebrew/homebrew#48850.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-02-17 09:18:21 +00:00
Mike McQuaid 691e4aec11 bin/brew: move logic to Library.
`bin/brew` is getting a bit bloated and it's annoying to open all of
`HOMEBREW_PREFIX` in your editor of choice and have it search through
the `Cellar`. Let's instead keep the bare minimum in `bin/brew` and
move the rest to `Library`.

Closes Homebrew/homebrew#49185.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-02-16 09:31:58 +00:00
Xu Cheng 4e51c0b8ea add Tap#formula_file?
Return true if given path would present a Formula file in this Tap.
Accepts both absolute path and relative path (relative to this Tap's path)

It offer an abstraction such that caller would not need to worry about
low level file system in the tap.

It will be used in `brew pull` and `brew update`.

Closes Homebrew/homebrew#49191.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-02-16 14:23:39 +08:00
Mike McQuaid 578e68b2c1 brew: remove ln from sudo command check list. 2016-02-15 11:39:41 +00:00
Mike McQuaid f6cbf7bab0 Move internal command aliases from Ruby to Bash.
This means that internal command aliases can be used for Bash commands
(such as the new, Bash-based `brew update`).

Fixes Homebrew/homebrew#49182.

Closes Homebrew/homebrew#49184.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-02-15 11:35:25 +00:00
Mike McQuaid 775c4eedd7 Promote update-bash to the default updater.
Also, rename the existing updater to `update-ruby` to allow using as
a fallback. It will eventually be removed.

Closes Homebrew/homebrew#49109.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-02-15 08:54:03 +00:00
Dominyk Tiller b389953f5b style: update rubocop to 0.37.2
Closes Homebrew/homebrew#49084.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-02-13 02:16:17 +00:00
Dominyk Tiller 44453cf829 telepathy-glib: boneyard
The Telepathy formulae are being shipped off to the boneyard.

1) The number of downloads per formula in terms of Bottles is less than 30 in
the space of 3 months.

2) Two of them were moved onto development releases in November and nobody noticed.

3) telepathy-gabble's executable has been broken since submission and nobody noticed.

4) Making telepathy-gabble's executable function requires significant changes to
d-bus, including enforcing a mandatory X11 dependency on telepathy-gabble users.

5) It's not particularly simple to write tests for the formulae which means they're
more likely to break without CI noticing.

Closes Homebrew/homebrew#49052.
2016-02-12 23:26:06 +00:00
Dominyk Tiller e805cbc700 telepathy-mission-control: boneyard 2016-02-12 23:26:06 +00:00
Dominyk Tiller c6b933dec6 telepathy-idle: boneyard 2016-02-12 23:26:06 +00:00
Dominyk Tiller bb94ca0f06 telepathy-gabble: boneyard 2016-02-12 23:26:06 +00:00
Mike McQuaid 59f1c24b43 cmd/update-bash.sh: print message on fetch fail.
Closes Homebrew/homebrew#49107.
Closes Homebrew/homebrew#49105.
Closes Homebrew/homebrew#48267.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-02-12 13:17:25 +00:00