Commit Graph
27507 Commits
Author SHA1 Message Date
Carlo Cabrera 28c0caae4d extend/os/mac/keg_relocate: remove RPATHs rooted in build directory
Keeping dangling `RPATH`s is a security risk, and is bad for build
reproducibility.
2021-05-14 01:07:14 +01:00
Rylan Polster 7c68b1738b Merge pull request #11332 from Rylan12/relocate-paths-at-start
keg_relocate: only replace matches at the start of a path
2021-05-13 12:19:06 -04:00
Rylan Polster 4457dc904b Cleanup using suggestions from code review 2021-05-13 11:02:39 -04:00
Mike McQuaid 321c165bd3 Merge pull request #11350 from Gcenx/audit-fix-xcode-build-check
audit: Remove SYMROOT
2021-05-13 13:50:40 +01:00
Mike McQuaid 02a344d432 Merge pull request #11368 from cnnrmnn/add-leaves-flags
Add leaves --installed-on-request and --installed-as-dependency flags
2021-05-13 13:33:29 +01:00
Mike McQuaid d849b5018d cmd/leaves: tweak naming. 2021-05-13 13:15:40 +01:00
Dean M Greer ceeb5ea9ec audit: Remove SYMROOT
SYMROOT is only a valid argument when -project is used.

xcodebuild has other uses than building Xcode projects.
2021-05-13 08:07:06 -04:00
Carlo Cabrera dd199901e7 Merge pull request #11370 from carlocab/relocate-metavars 2021-05-13 07:02:25 +01:00
Carlo Cabrera 526c06da0c Merge pull request #11375 from carlocab/relocate-dylib-id
extend/os/mac/keg_relocate: fix post-bottling dylib ID relocation
2021-05-12 22:15:31 +01:00
Carlo Cabrera c7de544fe8 extend/os/mac/keg_relocate: fix post-bottling dylib ID relocation
Running `brew bottle` changes dylib IDs, install names, and rpaths into
placeholders for the bottle, creates a bottle tarball, and then changes
the placeholders back to their correct values.

With my refactoring in #11358, the behaviour of this relocation changed:
dylib IDs would no longer be changed back from placeholders into their
correct values after the creation of the bottle tarball.
2021-05-12 21:37:33 +01:00
Rylan Polster 04ac61924b cli/args: add new brew leaves args to rbi file
Also update the manpages with the new `brew leaves` options.
2021-05-12 11:49:46 -04:00
cnnrmnn dd94c4a550 Revert "Add leaves flags tests"
This reverts commit 706c408696.
2021-05-12 11:25:53 -04:00
Bo Anderson 6b8ed45db3 Merge pull request #11140 from Bo98/io-read-cop
Add cop for IO.read usage
2021-05-12 16:05:40 +01:00
cnnrmnn 706c408696 Add leaves flags tests 2021-05-12 10:51:16 -04:00
cnnrmnn c20c7c8be5 Make flags mutually exclusive 2021-05-12 10:37:59 -04:00
cnnrmnn 8764c4fc21 Fix proc coercion 2021-05-12 10:08:11 -04:00
Connor MannandMike McQuaid e4e641cd77 Update Library/Homebrew/cmd/leaves.rb
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-05-12 10:05:02 -04:00
Bo Anderson a92c194bfb Merge pull request #11321 from Bo98/gzip
dev-cmd/bottle: make gzip creation consistent across platforms
2021-05-12 14:58:43 +01:00
Connor MannandCarlo Cabrera 47a64822ba Update Library/Homebrew/cmd/leaves.rb
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2021-05-12 09:36:51 -04:00
Bo Anderson 6d31408606 dev-cmd/bottle: make gzip creation consistent across platforms 2021-05-12 14:21:38 +01:00
Mike McQuaid 2e1e08c596 Merge pull request #11366 from MikeMcQuaid/delete-bintray
Delete Bintray code
2021-05-12 14:17:48 +01:00
Mike McQuaid b914411ac8 Delete Bintray code
Remove all code related to Bintray. It no longer works so there's no
point keeping it around.

Some of this could arguably be deprecated/disabled first/instead but:
I'm not sure I see the sense in keeping stuff around that's known to be
broken.
2021-05-12 13:37:18 +01:00
Bo Anderson e5285b5ed8 Add cop for IO.read usage 2021-05-12 13:07:24 +01:00
Bo Anderson 6c9ef43e72 Merge pull request #11309 from Bo98/exec-cop
rubocops/shell_commands: add cop for shell metacharacters in `exec`
2021-05-12 13:03:39 +01:00
Carlo Cabrera 4b6f7aaa5b extend/os/mac/keg_relocate: remove HOMEBREW_RELOCATE_METAVARS
It's not being used, and it breaks formulae when it is.

Plus do some extra refactoring.
2021-05-12 04:08:41 +01:00
cnnrmnn 5cc98d2819 Add --installed-(on-request/as-dependency) flags 2021-05-11 17:32:24 -04:00
Bo Anderson 92cf904719 Merge pull request #11362 from Bo98/json-tab-write
formula_installer: write tab when pouring local --only-json-tab bottles
3.1.7
2021-05-11 22:10:18 +01:00
Rylan Polster 309e9e1c52 Remove Keg::Relocation#start_with_old_value? method 2021-05-11 15:45:43 -04:00
Rylan Polster 7d49dba7e9 Fix Keg::Relocation::start_with_old_value? 2021-05-11 14:28:47 -04:00
Rylan Polster 875282bc06 Add more keg relocation tests 2021-05-11 14:28:47 -04:00
Rylan Polster f13f7b9326 Only use path regex when requested 2021-05-11 14:28:47 -04:00
Rylan Polster 5f781770b4 Extract Keg::text_matches_in_file from bottle command 2021-05-11 14:26:14 -04:00
Rylan Polster 08382fab0b Add tests for Keg::Relocation 2021-05-11 14:26:14 -04:00
Rylan Polster fe7f80f647 Refactor out and correctly create path regex 2021-05-11 14:26:14 -04:00
Rylan Polster fd3730a531 bottle: allow links to pkgconfig directory in HOMEBREW_REPOSITORY 2021-05-11 14:26:14 -04:00
Rylan Polster 9ddb531249 bottle: update keg_contain? to match correctly 2021-05-11 14:26:14 -04:00
Rylan Polster db8f54cea1 keg_relocate: only replace matches at the start of a path 2021-05-11 14:26:13 -04:00
Carlo Cabrera ef000d0c3b Merge pull request #11358 from carlocab/keg-relocate-refactor
extend/os/mac/keg_relocate: refactor `relocate_dynamic_linkage`
2021-05-11 19:22:45 +01:00
Bo Anderson 33e1255f65 formula_installer: write tab when pouring local --only-json-tab bottles 2021-05-11 14:28:12 +01:00
Bo Anderson 2b9fd5460e Merge pull request #11365 from Bo98/syscommand-queue
system_command: better handle race conditions when interrupting
2021-05-11 14:12:21 +01:00
Mike McQuaid f35bb422d4 Merge pull request #11349 from davidxia/fish-path
fix: use recommended way of updating Fish shell $PATH
2021-05-11 13:45:38 +01:00
Bo Anderson d83b8002ef system_command: better handle race conditions when interrupting 2021-05-11 13:44:32 +01:00
Bo Anderson fca0fb123d Merge pull request #11361 from Bo98/syscommand-race-fix
system_command: fix rare scenario of interrupt being reported to stderr
2021-05-11 03:19:50 +01:00
Bo Anderson b7782c670f Merge pull request #11360 from Bo98/perl-catalina
os/mac: use perl 5.18 on Catalina
2021-05-11 02:35:30 +01:00
Bo Anderson aea107b55a system_command: fix rare scenario of interrupt being reported to stderr 2021-05-11 02:32:29 +01:00
Bo Anderson 0950549629 os/mac: use perl 5.18 on Catalina 2021-05-11 01:48:54 +01:00
Dawid Dziurla 4e610a7075 Merge pull request #11359 from Homebrew/sorbet-files-update
sorbet: Update RBI files.
2021-05-11 02:26:13 +02:00
BrewTestBot 09a996181d sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2021-05-11 00:07:17 +00:00
Carlo Cabrera a1c4243dd7 extend/os/mac/keg_relocate: refactor relocate_dynamic_linkage
Following feedback from #11331.
2021-05-10 17:42:35 +01:00
Mike McQuaid c92a40a751 Merge pull request #11276 from scpeters/release_notes_fix_blank_link
release_notes: append #PR to markdown link text
2021-05-10 16:54:57 +01:00