Commit Graph
15287 Commits
Author SHA1 Message Date
Mike McQuaid 5dfa0cf622 keg: delete bad tap opt non-symlink directories.
But don't delete them if they are a symlink to a directory i.e. a normal
opt link.

Handles the issue mentioned in
https://github.com/Homebrew/brew/commit/1651647a3dc9dbc03ed3c5da06090228db4cd1a0#r28360427
2018-04-01 09:27:49 +01:00
Mike McQuaid 60d6b4d90d Merge pull request #4006 from MikeMcQuaid/no-more-official-taps
Remove mentions to official taps
2018-03-31 13:59:25 +01:00
Mike McQuaid 49038a2cd9 Remove mentions to official taps
There are none remaining. We don’t want PHP to get the deprecated
messages until all formulae have been deleted so that will be in a
later PR.
2018-03-31 13:42:33 +01:00
Mike McQuaid 07997d41e8 Merge pull request #4004 from MikeMcQuaid/usability
Address some usability issues.
2018-03-30 16:30:07 +01:00
Mike McQuaid 33b5ac78ad cmd/switch: improve usability.
- Ensure that we output the available versions where relevant
- Use `<formula>` to be consistent with other commands’ help
- General code cleanup
2018-03-30 15:19:13 +01:00
Mike McQuaid 5b68bb84d2 cmd/upgrade: output the outdated version.
This makes it clearer what version is being updated to what version.
2018-03-30 15:00:45 +01:00
Mike McQuaid ed8cae93ab cmd/install: mention brew reinstall
If people are trying to `brew install` an existing version it’s worth
pointing out to them how they can reinstall (as it’s pretty much the
only case where we’re not already suggesting another command).
2018-03-30 14:58:36 +01:00
Mike McQuaid 4c07685258 cmd/help: usability tweaks.
- Don’t mention `brew home` or `brew options` as their output is in
  `brew info` (and the `(…|…)` is weird.
- Use full length flags for `-v` and `-d` to make more obvious what
  they are doing
- Don’t use `Developers`; instead point out it’s how you contribute
- Mention `brew commands` for `COMMAND` output (like we do with
  `FORMULA` and `brew search`)
- Point towards `docs.brew.sh`
2018-03-30 14:57:38 +01:00
Markus Reiter cc2d9d926e Merge pull request #4002 from reitermarkus/tap-path-loader
Use `TapPathLoader` in more cases.
2018-03-29 22:19:53 +02:00
Markus Reiter 94f2098c36 Only use HOMEBREW_TAP_PATH_REGEX once inside Tap class. 2018-03-29 22:05:02 +02:00
Markus Reiter db2cd52842 Use TapPathLoader in more cases. 2018-03-29 21:56:32 +02:00
Markus Reiter 40e7ac2632 Merge pull request #4001 from reitermarkus/rubocop-0.54
Update to RuboCop 0.54
2018-03-29 21:20:01 +02:00
Markus Reiter 8a29244965 Update to RuboCop 0.54 2018-03-29 21:07:04 +02:00
Mike McQuaid cd30820def Merge pull request #3999 from MikeMcQuaid/leaves-handle-missing-formulae
cmd/leaves: handle missing formulae.
2018-03-29 14:12:56 +01:00
Mike McQuaid ce9c8c6808 cmd/leaves: handle missing formulae.
We can't get dependencies of unavailable formulae so don't try.

Fixes #3995.
2018-03-29 10:58:01 +01:00
Mike McQuaid 6654ff6e13 Merge pull request #3996 from GauthamGoli/common-switch
cli_parser: Add :quiet, :verbose, :debug common switches
2018-03-29 08:15:39 +01:00
Mike McQuaid 62e855c863 Merge pull request #3998 from kabel/rubocop-dependency-order-tags
audit: Fix dependency order with multiple tags
2018-03-29 08:15:04 +01:00
Mike McQuaid ffc26a2dd5 Merge pull request #3994 from commitay/cask-audit-spec
cask audit_spec: rspec auto-corrects
2018-03-29 08:14:11 +01:00
Kevin Abel 1b22e16a08 rubocop: Fix audit for dependency order with multiple tags
Dependencies that have multiple tags (`[:build, :test]`) get sorted into
multiple locations resulting in the cop always reporting an offense
regardless of order.
2018-03-28 20:54:39 -05:00
Gautham Goli 8ef1fb30a0 Add :quiet, :verbose, :debug common switches to be specified 2018-03-29 03:20:14 +05:30
commitay ca881b3d68 cask audit_spec: rspec auto-corrects 2018-03-28 22:06:01 +10:00
Mike McQuaid 0f4e22e28d Merge pull request #3981 from MikeMcQuaid/rspec-cleanup
test: rubocop-rspec style auto-corrects.
1.5.13
2018-03-28 11:51:44 +01:00
Mike McQuaid dda1dd54eb Merge pull request #3982 from MikeMcQuaid/rubocop-rspec
style: add optional rubocop-rspec support.
2018-03-28 11:21:56 +01:00
Mike McQuaid 262666c828 cleanup_spec: add nicer prune matcher alias. 2018-03-28 11:20:57 +01:00
Mike McQuaid d1b83819de Merge pull request #3979 from MikeMcQuaid/runtime_dependencies_changes
Make runtime dependencies handling more consistent
2018-03-28 09:13:46 +01:00
commitay c1cab8a24d Merge pull request #3992 from commitay/cask-audit-latest-appcast
cask audit: check for :latest with appcast
2018-03-28 09:53:12 +10:00
Mike McQuaid 8975bf0d5b keg: use Formula#runtime_dependencies. 2018-03-27 14:52:48 +01:00
Mike McQuaid 74d6d39e45 deps: use Formula#runtime_dependencies. 2018-03-27 14:52:48 +01:00
Mike McQuaid ff7294ee1f uses: use Formula#runtime_dependencies. 2018-03-27 14:52:47 +01:00
Mike McQuaid 42a39b16bf formula: use runtime_dependencies from tab.
Don't do so in `linkage_checker` or `tab` which to avoid recursive loops
and want the actual values specified in the formula itself.
2018-03-27 14:52:47 +01:00
Mike McQuaid a7727b66b3 keg: add tab, runtime_dependencies methods. 2018-03-27 14:52:47 +01:00
Mike McQuaid 6fec707059 Formula#missing_dependencies: use runtime_dependencies. 2018-03-27 14:52:47 +01:00
Mike McQuaid 0a73b0b423 formula: require tab. 2018-03-27 14:52:47 +01:00
Mike McQuaid d8bf3f8d60 tab: default runtime_dependencies to nil. 2018-03-27 14:52:47 +01:00
Mike McQuaid 046ebfb647 diagnostic: general cleanup. 2018-03-27 14:52:47 +01:00
Mike McQuaid 05d06bcc50 cmd/leaves: general cleanup. 2018-03-27 14:52:47 +01:00
commitay 2373ee6168 cask audit: check for :latest with appcast 2018-03-27 20:56:05 +10:00
Markus Reiter 32d1f6db8b Fix described_class in custom matcher. 2018-03-27 11:05:57 +02:00
commitay 0851f96710 Merge pull request #3990 from commitay/cask-audit-github-appcast
cask audit: check for appcast if the cask uses github releases
2018-03-27 16:32:16 +10:00
commitay 4020f50c14 cask audit: check for appcast if the cask uses github releases 2018-03-27 16:17:37 +10:00
commitay 594ff9283c Merge pull request #3974 from commitay/cask-audit-pkg
cask audit: check for allow_untrusted within caskroom taps
2018-03-27 16:12:55 +10:00
Markus Reiter 8453ea3ed8 Merge pull request #3991 from commitay/cask-audit-various
cask audit: various
2018-03-27 06:37:39 +02:00
commitay 43244e7953 cask audit: check allow_untrusted 2018-03-27 08:57:39 +10:00
commitay f9c557bc1a cask audit: capitalize Cask 2018-03-27 08:52:35 +10:00
commitay 108c65b43e cask audit: use @cask.tap 2018-03-27 08:52:26 +10:00
Mike McQuaid 6034caf9fb Merge pull request #3986 from amancevice/detect-bottle-strategy
Detect bottle download strategy
2018-03-25 19:23:03 +01:00
Mike McQuaid 6a56181dcd Merge pull request #3985 from HaraldNordgren/brew_install__search_casks_if_not_found
brew install: search casks if not found
2018-03-25 19:22:14 +01:00
Alexander Mancevice 138d4df710 Detect bottle download strategy
Use ::detect method of DownloadStrategyDetector to detect download strategy of a bottle from its root_url.

This allows bottle root_urls to be s3:// style URLs and be handled by the S3DownloadStrategy without specifying ':using =>'
2018-03-25 13:45:58 -04:00
Harald Nordgren 5db2ed4fbf brew install: search casks if not found 2018-03-25 19:14:14 +02:00
Mike McQuaid d9e3ff6578 Merge pull request #3984 from GauthamGoli/update-test-args
update-test: Use Parser to parse args
2018-03-25 17:39:55 +01:00