Commit Graph
19294 Commits
Author SHA1 Message Date
fauxpark c46244dc3d completions/zsh: add --greedy argument for brew cask outdated 2019-10-21 20:07:20 +11:00
Mike McQuaid 8b4c8159de Merge pull request #6621 from Amar1729/patch-2
[Interesting Taps and Forks] Update unmaintained ffmpeg tap to Current
2019-10-21 09:23:11 +01:00
Mike McQuaid 253e45bb94 Merge pull request #6618 from xu-cheng/arm
brew test: more fixes for ARM
2019-10-21 09:08:10 +01:00
Amar Paul 5dddbf1e8c Update unmaintained ffmpeg tap to current 2019-10-20 20:52:48 -04:00
Cheng XU 163ef284d2 brew test: more fixes for ARM
On ARMv7, the arch name is armv7l instead of armv7. So update the bottle
file name accordingly.
2019-10-19 15:20:35 +08:00
Mike McQuaid e985986835 Merge pull request #6617 from xu-cheng/arm
brew tests: fix for ARM
2019-10-18 17:06:04 +01:00
Cheng XU 0db4287326 formula_info: use RUBY_PATH instead of calling HOMEBREW_BREW_FILE
This ensures correct RUBY_PATH is used when running `brew tests` with
custom `HOMEBREW_RUBY_PATH`

More info: https://github.com/Homebrew/brew/pull/6617#discussion_r336431131
2019-10-18 22:15:52 +08:00
Markus Reiter dd839c7903 Merge pull request #6615 from reitermarkus/shellenv
Fix `shellenv` when using `-u`.
2019-10-18 16:03:41 +02:00
Mike McQuaid d3d8869468 Merge pull request #6582 from EricFromCanada/doctor-modified-files
doctor: list any uncommitted modified files in CI
2019-10-18 09:49:42 +01:00
Mike McQuaid 1e3ddcade1 diagnostic: tweak modified detection. 2019-10-18 09:22:34 +01:00
Cheng XU c98b77fd3e cpu_spec: fix for ARM 2019-10-18 15:33:28 +08:00
Cheng XU f0e848b3e0 fixtures: add testball bottle for ARM
Also fix the absolute link used by testball_bottle-0.1.intel_macintosh.bottle.tar.gz
2019-10-18 15:30:24 +08:00
Markus Reiter 59866d25ea Fix shellenv when using -u. 2019-10-17 20:14:01 +02:00
EricFromCanada 6bc1785c88 doctor: list any uncommitted modified files 2019-10-16 17:43:51 -04:00
Markus Reiter 2bf8015bc4 Merge pull request #6613 from reitermarkus/match-nil
Fix `#match?` on `nil`.
2.1.15
2019-10-16 20:25:31 +02:00
Markus Reiter 6cff8aff90 Fix cop for interpolated strings. 2019-10-16 19:06:39 +02:00
Markus Reiter 3d0fae4621 Fix #match? on nil. 2019-10-16 18:37:28 +02:00
Mike McQuaid 13b79e7b1a Merge pull request #6612 from MikeMcQuaid/clt-clang-version-fallback
os/mac/xcode: fallback to clang version for detecting CLT.
2019-10-16 16:53:37 +01:00
Mike McQuaid aae9d39939 os/mac/xcode: fallback to clang version for detecting CLT.
For some reason `pkgutil --pkgs` no longer lists the CLT after the
Catalina supplemental update.

Fixes https://github.com/Homebrew/brew/issues/6610
2019-10-16 16:26:57 +01:00
Mike McQuaid 48f54d17f8 Merge pull request #6595 from sjackman/portable-ruby-aarch64
vendor-install: Add ruby bottle for aarch64
2019-10-16 14:16:57 +01:00
Mike McQuaid a69d28c23e Merge pull request #6609 from xu-cheng/bottle
bottle: do not install patchelf if --skip-relocation flag is passed
2019-10-16 08:56:27 +01:00
Cheng XU 94cf0d922e bottle: do not install patchelf if --skip-relocation flag is passed 2019-10-16 14:29:53 +08:00
Markus Reiter 9e337978d9 Merge pull request #6606 from reitermarkus/quarantine-symlinks
Skip quarantining symlinks.
2019-10-15 19:16:08 +02:00
Markus Reiter 16b3cb0d71 Skip quarantining symlinks. 2019-10-15 18:32:37 +02:00
Markus Reiter d24f3c3b99 Merge pull request #6605 from reitermarkus/missing-command-method
Fix missing `command` method.
2019-10-15 18:05:22 +02:00
Markus Reiter 40a0b8b10a Fix missing command method. 2019-10-15 17:39:15 +02:00
Mike McQuaid 334f151268 Merge pull request #6604 from MikeMcQuaid/update-maintainers
README: update maintainers.
2019-10-15 15:55:17 +01:00
Mike McQuaid cbde3e2ce2 README: update maintainers.
Some arriving, some leaving.
2019-10-15 14:03:06 +01:00
Mike McQuaid 675e38b5e4 Merge pull request #6602 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-0.75.1
build: bump rubocop from 0.75.0 to 0.75.1 in /Library/Homebrew
2019-10-15 12:17:09 +01:00
dependabot-preview[bot] dfb33d6f3f build: bump rubocop from 0.75.0 to 0.75.1 in /Library/Homebrew
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.75.0 to 0.75.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.75.0...v0.75.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 10:15:05 +00:00
Mike McQuaid b92fafbb6b Merge pull request #6603 from MikeMcQuaid/tests-raise-deprecation-exceptions
Raise deprecation exceptions in tests
2019-10-15 10:51:56 +01:00
Mike McQuaid 8a93230c15 test/cask: remove disabled functionality tests. 2019-10-15 09:52:33 +01:00
Mike McQuaid 02ded996a4 formulary_spec: remove deprecated tap-pin usage. 2019-10-15 09:13:11 +01:00
Mike McQuaid 1b4fdc17f4 Raise deprecation exceptions in tests
Previously tests which hit `odeprecated` would print warnings but not
always raise exceptions or fail. Combine this with the ability to have
`odeprecated` to turn into `odisabled` on certain dates and you have
tests that may fail just on the clock changing (this is bad).

Instead, ensure that tests always raise deprecations as exceptions so
that new deprecations will have their tests handled immediately.
2019-10-15 08:52:42 +01:00
Markus Reiter 8fa65aaabf Merge pull request #6598 from amyspark/workaround-xattr
Cask: only quarantine working symlinks
2019-10-14 20:25:44 +02:00
L. E. Segovia ed7327296a Cask: only quarantine working symlinks
Fixes Homebrew/homebrew-cask#70796
2019-10-14 15:38:41 +00:00
Markus Reiter 455bb3e05b Merge pull request #6597 from reitermarkus/semantics
Move condition to nested `if` statement.
2019-10-14 12:16:18 +02:00
Markus Reiter f762033a57 Move condition to nested if statement. 2019-10-14 11:28:30 +02:00
Markus Reiter 9a857ccf9b Merge pull request #6596 from reitermarkus/dmg
Fix `Dmg` detection.
2019-10-14 11:28:20 +02:00
Markus Reiter cc234d1948 Fix Dmg detection. 2019-10-14 10:44:52 +02:00
Issy Long d0c3885f31 Merge pull request #6592 from issyl0/bump-rubocop-target-ruby-version
Bump Rubocop's `TargetRubyVersion` to 2.6 and fix all offenses
2019-10-14 09:39:21 +01:00
Mike McQuaid cbf458ea9c Lint/ElseAlignment: ignore some bugged autocorrections. 2019-10-14 09:03:02 +01:00
Mike McQuaid f1702e5139 Merge pull request #6591 from amyspark/fix-depth-upgrade-check
upgrade: reject formulae checked in earlier levels
2.1.14
2019-10-14 08:44:10 +01:00
Issy Long 1f6168fe8a Change regexp.match?(string) to string.match?(regexp) everywhere
- Only try to call `.match?` on strings that aren't nil.
2019-10-13 23:22:51 +01:00
Shaun Jackman c71b540ea6 vendor-install: Add ruby bottle for aarch64 2019-10-13 14:24:08 -07:00
Markus Reiter eac74ec6e6 Merge pull request #6594 from reitermarkus/tar-dmg
Fix `Dmg` being detected as `Tar`.
2019-10-13 22:10:45 +02:00
Markus Reiter 67d51ef0e1 Fix Dmg being detected as Tar. 2019-10-13 17:19:02 +02:00
Issy Long 18e684fad7 Stringify dev-cmd/audit text variables when used in Regexp matching
- To have the audit commands continue to work, and the tests passing
  (the previous error was [1]), everywhere we're trying to
  `.match?(text)`, instead do `.match?(text.to_s)`.

[1] 5) Homebrew::FormulaAuditor#audit_file __END__ but no DATA
    Failure/Error: fa.audit_file

    TypeError:
      no implicit conversion of Homebrew::FormulaText into String
    # ./dev-cmd/audit.rb:267:in `match?'
    # ./dev-cmd/audit.rb:267:in `audit_file'
    # ./test/dev-cmd/audit_spec.rb:137:in `block (3 levels) in <module:Homebrew>'
2019-10-13 16:04:38 +01:00
Issy Long fed1bbe029 Disable Metrics/LineLength for long URL lines in patches_spec.rb
- The final two `brew style` offenses were for Metrics/LineLength where
  parsing the GitHub diff URL as a regex took 119/118 lines.
- This disables the cop for each of those long, problematic lines, and
  re-enables them straight afterwards, else they'd apply to the whole file
  from the first occurrence onwards, which we probably don't want?
- I wondered about increasing the LineLength limit to 119 or 120, but
  it appears to have been set for a justifiable reason in 80d75bc0d8.
2019-10-13 16:04:37 +01:00
Issy Long 3570cb6e77 Auto-fix Style/NegatedUnless offenses 2019-10-13 16:04:36 +01:00