The threading in the tap search code makes handling errors difficult. If
an API-related error is raised in one thread, it is likely to be raised
in each of the rest as well. This results in duplicated error messages,
which is ugly and bad UX.
This patch adds a synchronized queue to collect these exceptions. The
first one added to the queue is re-raised after all operations are
complete.
It's not ideal, but it's minimally invasive and I don't have the energy
or time to do a rewrite.
Let's check for e.g. --help anywhere in the ARGV array rather than just
the first value to avoid brew upgrade --help causing problems.
ClosesHomebrew/homebrew#26675.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
This commit adds additional formatting options to the graph. Most noticeable is a top-to-bottom layout (rather than the previous left-to-right), and nicer fonts on everything.
More subtly, the ranking mechanism has been updated so that the "Safe to Remove" cluster is always at the highest rank (fixing a bug where non-leaf nodes could have been placed next to it,) and added better margins and padding. The rank separation was also decreased for a more compact graph.
Under the hood, the GraphViz output code was updated to support attributes with a list of sub-attributes (for example, 'graph [fontsize="11", fontname="Helvetica"]') and to not put quotes around HTML-like labels in clusters.
ClosesHomebrew/homebrew#26651.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
This reverts commit c32ab0a35a2dfa9b593f759ef0ae8b7af077b0b7.
There are other hard-coded uses of HEAD, in build_options for instance.
These all need to be fixed before enabling this.
This change allows users to install the `launchctl` wrapper in the
`reattach-to-user-namespace` formula which makes the command work in
Tmux and other non-standard environments.
ClosesHomebrew/homebrew#26609.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
This doesn't handle paginated results, but it fetches the 100 most
starred results so that's probably good enough for now.
FixesHomebrew/homebrew#26566.
Homebrew currently recognizes "--head" during the install process, but
rather than actually fetch HEAD it just nags the user to use the
correct option. Since we recognize the spelling anyway, this just
promotes the lowercase version to an official alias.
ClosesHomebrew/homebrew#26555.
The example formula had no information about how
to find the current bulding directory. Now it has ;)
ClosesHomebrew/homebrew#26554.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Jack Nagel