Commit Graph
454 Commits
Author SHA1 Message Date
Slava Bezgachev 113ffa7ba2 Removed redundant parameter
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-20 10:22:03 +06:00
Slava Bezgachev eef8ca8415 Slight refactor
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-20 10:19:28 +06:00
Slava Bezgachev da0f429bd0 Forgot to change the string
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-20 10:16:54 +06:00
Slava Bezgachev 31ac0396b2 Added reviewed changes
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-20 10:16:17 +06:00
Slava Bezgachev eebddf449f Rolled the handlechange function to original
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-19 09:44:00 +06:00
Slava Bezgachev e27cc4235e Altered the validation functions a little for clarity
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-19 09:40:02 +06:00
Slava Bezgachev 1be9944f57 updated file header text for tests
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-19 09:33:43 +06:00
Slava Bezgachev c78f3f626b Updated as per the code review
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-19 09:27:17 +06:00
Slava Bezgachev d59130a413 Fixed the tests. Changed simulating button clicks to simulating a form submission. Tests should pass now
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-18 22:22:27 +06:00
Slava Bezgachev 4dbdbfb357 Made the changes, now to fix the broken tests
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-18 22:09:48 +06:00
Slava Bezgachev 858bc5bec9 Changed <div> to <form>, allows for "native" press Enter to submit
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-18 21:56:46 +06:00
Slava Bezgachev c5e178f986 Boy am I bad with regex. Fixed tests, seems ok for now
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-18 21:48:34 +06:00
Slava Bezgachev 359477f67b Adding fairly comprehensive tests, some still need fixing
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-18 21:36:13 +06:00
Slava Bezgachev eac8cbdf03 Added first version of the validate functions, now to test them
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-18 20:35:44 +06:00
Slava Bezgachev 790ed513b8 FIxed typos and errors, moved validate to separate file
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-18 20:09:36 +06:00
Slava Bezgachev 4398e678dd Added some basic Enzyme unit tests, made onInputValidate function optional
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-17 21:04:53 +06:00
Slava Bezgachev c85d8fb5c8 Added minimum length for domains, also applies green styles to the input if valid
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-17 20:00:56 +06:00
Slava Bezgachev 2ae549e4a5 Added client-side regex validation of domains in Domain Lists (whitelist and blacklist)
Signed-off-by: Slava Bezgachev <bezgachev@gmail.com>
2018-10-17 19:58:56 +06:00
Mark Drobnak 8c5d96ba6e Merge pull request #82 from pi-hole/fix/login-redirect
Use BrowserRouter and fix login page redirection
2018-10-15 11:30:52 -04:00
Mcat12 02fa375af9 Use BrowserRouter and fix login page redirection
The login page was refreshing the whole page and not redirecting to the
correct page (if you tried to load a protected page without auth).

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-10-15 11:24:07 -04:00
Mark Drobnak 972985d7c0 Merge pull request #80 from pi-hole/feature/network-settings
Reorganize Network Settings
2018-09-02 15:54:42 -04:00
Mark Drobnak f6177512b0 Merge branch 'development' into feature/network-settings 2018-09-01 21:50:04 -04:00
Mark Drobnak 398e8b0c82 Merge pull request #79 from pi-hole/tweak/sidebar-title
Use "Status" for sidebar title
2018-08-18 17:32:30 -04:00
Mcat12 072f957da4 Use "Status" for sidebar title
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-18 17:30:24 -04:00
Mcat12 2e5303a031 Make labels bold in network info
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-18 16:46:40 -04:00
Mcat12 426fbcd1b7 Use a top tab layout in network settings
The network info page now uses a form to display the data

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-18 16:42:01 -04:00
Mark Drobnak b7ed535711 Merge pull request #78 from pi-hole/tweak/generate-routes
WEB-CR-7 Generate route data from the existing navigation data
2018-08-18 15:58:45 -04:00
Mcat12 e0c22465be Generate route data from the existing navigation data
This fixes a bug where the settings endpoints were able to be accessed
without authentication (the API still requires auth, so no data would
have been shown).

A slight change was made to the wording of the login page redirect.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-18 15:56:39 -04:00
Mark Drobnak 08967692b8 Merge pull request #77 from pi-hole/fix/settings-strings
WEB-CR-6 Fix missing translation string errors in settings
2018-08-18 15:21:12 -04:00
Mcat12 4aa9c715e0 Fix missing translation string errors in settings
This also fixes an HTML error where there was a missing `<tbody>` tag
in the version cards.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-18 15:18:31 -04:00
Mark Drobnak 436b621b25 Merge pull request #76 from pi-hole/update/translations
WEB-CR-5 Update Translations 8/18/2018
2018-08-18 14:53:19 -04:00
Mcat12 e036c770cf Update Translations 8/18/2018
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-18 14:26:49 -04:00
Mark Drobnak bdcf521600 Merge pull request #75 from pi-hole/tweak/version-card
WEB-CR-3 Improve version cards with general version and detailed version info
2018-08-18 14:15:55 -04:00
Mcat12 e9641b03bd Improve version cards with general version and detailed version info
The versions page is more responsive as well.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-18 14:02:43 -04:00
Mark Drobnak a6be8ade04 Merge pull request #74 from pi-hole/tweak/restructure-components
Organize components into folders based on where they are used
2018-08-18 11:40:09 -04:00
Mark Drobnak c1b01e419f Merge branch 'development' into tweak/restructure-components 2018-08-18 11:36:23 -04:00
Mcat12 61cc62306e Organize components into folders based on where they are used
For example, dashboard components go into the dashboard folder,
settings components go into the settings folder, and components
used in multiple places go into the common folder.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-18 11:34:35 -04:00
Mark Drobnak bd6e7ee518 Merge pull request #73 from pi-hole/fix/ci-tag
Use the correct env variable when checking if this is a tag build
2018-08-18 11:16:40 -04:00
Mcat12 93fa41cfad Store tag builds in folder named after tag
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-16 11:13:42 -04:00
Mcat12 2751b09ef0 Use the correct env variable when checking if this is a tag build
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-16 10:55:29 -04:00
Mark Drobnak 2683c6be13 Merge pull request #71 from pi-hole/fix/deploy-workflow
Fix deploy job not running on master branch
2018-08-01 22:04:42 -04:00
Mcat12 52b45832ac Remove old filter from deploy job
It was moved to the workflow, and is now obsolete.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-01 22:00:16 -04:00
Mcat12 462bab4b2e Fix deploy job not running on master branch
Without a workflow, only the "build" job is run.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-01 21:53:17 -04:00
Mark Drobnak 9d824d7ff6 Merge pull request #69 from pi-hole/update/translations
Update translations
2018-07-31 22:01:11 -04:00
Mcat12 8e0034ec70 Update translations
New are Bulgarian, Portuguese, and Spanish

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-07-31 21:58:40 -04:00
Mark Drobnak bb12677671 Merge pull request #68 from pi-hole/feature/tests
Add tests
2018-07-23 17:24:21 -04:00
Mcat12 35bbda41d7 Add tests for ListPage
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-07-22 14:25:49 -04:00
Mcat12 243213f9df Merge remote-tracking branch 'origin/development' into feature/tests 2018-07-08 18:22:01 -04:00
Mcat12 1a13f56cd4 Add title test for GenericDoughnutChart
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-07-08 18:21:32 -04:00
Mcat12 78e6706e31 Add title and API callback tests for GenericDoughnutChart
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-07-08 18:11:04 -04:00