vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-29 00:44:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Query: Ensure that sticky post query returns all sticky posts.

Browse Source 
Ensure that the `posts_per_page` parameter submit to sticky post query matches the number of sticky posts requested. 

Follow-up to [52982]

Props Spacedmonkey, peterwilsoncc.
See #36907.



git-svn-id: https://develop.svn.wordpress.org/trunk@52990 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jonny Harris
2022-03-25 09:54:52 +00:00
parent 68cfd584ab
commit 1792018b4b
2 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/wp-includes/class-wp-query.php
View File

@@ -3263,6 +3263,7 @@ class WP_Query {
'post__in' => $sticky_posts,
'post_type' => $post_type,
'post_status' => 'publish',
'posts_per_page' => count( $sticky_posts ),
'suppress_filters' => $q['suppress_filters'],
'cache_results' => $q['cache_results'],
'update_post_meta_cache' => $q['update_post_meta_cache'],

23
tests/phpunit/tests/query/stickies.php
View File

@@ -126,4 +126,27 @@ class Tests_Query_Stickies extends WP_UnitTestCase {
$this->assertTrue( $sticky_query_vars['ignore_sticky_posts'] );
$this->assertTrue( $sticky_query_vars['no_found_rows'] );
}
/**
* @ticket 36907
*/
public function test_stickies_should_limit_query() {
$sticky_count = 6;
$post_date = gmdate( 'Y-m-d H:i:s', time() - 10000 );
$post_ids = self::factory()->post->create_many( $sticky_count, array( 'post_date' => $post_date ) );
add_filter(
'pre_option_sticky_posts',
function () use ( $post_ids ) {
return $post_ids;
}
);
$filter = new MockAction();
add_filter( 'posts_pre_query', array( $filter, 'filter' ), 10, 2 );
$this->go_to( '/' );
$filter_args = $filter->get_args();
$sticky_query_vars = $filter_args[1][1]->query_vars;
$this->assertSame( $sticky_query_vars['posts_per_page'], $sticky_count );
}
}