vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-11 20:30:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Code Modernization: Rename parameters that use reserved keywords in phpunit/tests/kses.php.

Browse Source 
While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the `$global` parameter to `$global_name` in `Tests_Kses::test_kses_globals_are_defined()`.

Follow-up to [52229], [54203], [55090].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

git-svn-id: https://develop.svn.wordpress.org/trunk@55131 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2023-01-24 16:03:26 +00:00
parent b1363cc7fe
commit 1f28106a14
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/kses.php
+5 -5
View File
@@ -2092,10 +2092,10 @@ HTML;
*
* @ticket 54060
*
* @param string $global The name of the global variable.
* @param string $global_name The name of the global variable.
*/
public function test_kses_globals_are_defined( $global ) {
$this->assertArrayHasKey( $global, $GLOBALS );
public function test_kses_globals_are_defined( $global_name ) {
$this->assertArrayHasKey( $global_name, $GLOBALS );
}
/**
@@ -2104,13 +2104,13 @@ HTML;
* @return array
*/
public function data_kses_globals_are_defined() {
$globals = array(
$required_kses_globals = array(
'allowedposttags',
'allowedtags',
'allowedentitynames',
'allowedxmlentitynames',
);
return $this->text_array_to_dataprovider( $globals );
return $this->text_array_to_dataprovider( $required_kses_globals );
}
}