vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-11 20:30:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.

Browse Source 
Reverts [27990] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.


git-svn-id: https://develop.svn.wordpress.org/trunk@28113 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Andrew Nacin
2014-04-14 07:47:10 +00:00
parent e1c90794e5
commit 32721b8347
2 changed files with 55 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wp-admin/includes/post.php
+8 -3
View File
@@ -433,7 +433,12 @@ function bulk_edit_posts( $post_data = null ) {
}
$updated = $skipped = $locked = array();
$shared_post_data = $post_data;
foreach ( $post_IDs as $post_ID ) {
// Start with fresh post data with each iteration.
$post_data = $shared_post_data;
$post_type_object = get_post_type_object( get_post_type( $post_ID ) );
if ( !isset( $post_type_object ) || ( isset($children) && in_array($post_ID, $children) ) || !current_user_can( 'edit_post', $post_ID ) ) {
@@ -482,13 +487,13 @@ function bulk_edit_posts( $post_data = null ) {
$post_data['ID'] = $post_ID;
$post_data['post_ID'] = $post_ID;
$translated_post_data = _wp_translate_postdata( true, $post_data );
if ( is_wp_error( $translated_post_data ) ) {
$post_data = _wp_translate_postdata( true, $post_data );
if ( is_wp_error( $post_data ) ) {
$skipped[] = $post_ID;
continue;
}
$updated[] = wp_update_post( $translated_post_data );
$updated[] = wp_update_post( $post_data );
if ( isset( $post_data['sticky'] ) && current_user_can( $ptype->cap->edit_others_posts ) ) {
if ( 'sticky' == $post_data['sticky'] )
tests/phpunit/tests/admin/includesPost.php
+47 -5
View File
@@ -5,6 +5,11 @@
*/
class Tests_Admin_includesPost extends WP_UnitTestCase {
function tearDown() {
wp_set_current_user( 0 );
parent::tearDown();
}
function test__wp_translate_postdata_cap_checks_contributor() {
$contributor_id = $this->factory->user->create( array( 'role' => 'contributor' ) );
$editor_id = $this->factory->user->create( array( 'role' => 'editor' ) );
@@ -56,8 +61,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$this->assertInstanceOf( 'WP_Error', $_results );
$this->assertEquals( 'edit_others_posts', $_results->get_error_code() );
$this->assertEquals( 'You are not allowed to edit posts as this user.', $_results->get_error_message() );
wp_set_current_user( 0 );
}
function test__wp_translate_postdata_cap_checks_editor() {
@@ -111,8 +114,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$this->assertNotInstanceOf( 'WP_Error', $_results );
$this->assertEquals( $_post_data['post_author'], $_results['post_author'] );
$this->assertEquals( 'draft', $_results['post_status'] );
wp_set_current_user( 0 );
}
/**
@@ -133,7 +134,48 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
);
edit_post( $post_data );
$this->assertEquals( 'draft', get_post( $post->ID )->post_status );
wp_set_current_user( 0 );
}
/**
* @ticket 27792
*/
function test_bulk_edit_posts_stomping() {
$admin = $this->factory->user->create( array( 'role' => 'administrator' ) );
$users = $this->factory->user->create_many( 2, array( 'role' => 'author' ) );
wp_set_current_user( $admin );
$post1 = $this->factory->post->create( array(
'post_author' => $users[0],
'comment_status' => 'open',
'ping_status' => 'open',
'post_status' => 'publish',
) );
$post2 = $this->factory->post->create( array(
'post_author' => $users[1],
'comment_status' => 'closed',
'ping_status' => 'closed',
'post_status' => 'draft',
) );
$request = array(
'post_type' => 'post',
'post_author' => -1,
'ping_status' => -1,
'comment_status' => -1,
'_status' => -1,
'post' => array( $post1, $post2 ),
);
$done = bulk_edit_posts( $request );
$post = get_post( $post2 );
// Check that the first post's values don't stomp the second post.
$this->assertEquals( 'draft', $post->post_status );
$this->assertEquals( $users[1], $post->post_author );
$this->assertEquals( 'closed', $post->comment_status );
$this->assertEquals( 'closed', $post->ping_status );
}
}