vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-30 23:30:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Media Grid: hasNext and hasPrevious are functions that must be called. Otherwise they are always truthy properties.

Browse Source 
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29072 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2014-07-10 18:09:46 +00:00
parent e8ce4559ed
commit 3c9fa4d68e
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/wp-includes/js/media-grid.js
View File

@@ -432,8 +432,8 @@
this.on( 'router:render', this.browseRouter, this );
}
this.options.hasPrevious = ( this.options.library.indexOf( this.options.model ) > 0 ) ? true : false;
this.options.hasNext = ( this.options.library.indexOf( this.options.model ) < this.options.library.length - 1 ) ? true : false;
this.options.hasPrevious = this.hasPrevious();
this.options.hasNext = this.hasNext();
// Initialize modal container view.
if ( this.options.modal ) {
@@ -545,8 +545,9 @@
* Click handler to switch to the previous media item.
*/
previousMediaItem: function() {
if ( ! this.options.hasPrevious )
if ( ! this.hasPrevious() ) {
return;
}
this.modal.close();
this.trigger( 'edit:attachment:previous', this.model );
},
@@ -555,8 +556,9 @@
* Click handler to switch to the next media item.
*/
nextMediaItem: function() {
if ( ! this.options.hasNext )
if ( ! this.hasNext() ) {
return;
}
this.modal.close();
this.trigger( 'edit:attachment:next', this.model );
},
@@ -588,14 +590,14 @@
}
// The right arrow key
if ( event.keyCode === 39 ) {
if ( ! this.hasNext ) {
if ( ! this.hasNext() ) {
return;
}
this.nextMediaItem();
}
// The left arrow key
if ( event.keyCode === 37 ) {
if ( ! this.hasPrevious ) {
if ( ! this.hasPrevious() ) {
return;
}
this.previousMediaItem();