vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Users: Replace table tags for color palettes in profiles.

Browse Source 
Replace the `table` element used to present color palette selection in the user profile screen with generic elements. The extra semantics of a table are at best unhelpful and have some potential to great extraneous verbosity for screen readers.

Props sabernhardt, desrosj.
Fixes #53157.

git-svn-id: https://develop.svn.wordpress.org/trunk@57572 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Joe Dolson 2024-02-08 23:29:18 +00:00
parent 334555fa42
commit 533bbd14bd
2 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/wp-admin/css/forms.css
View File

@ -933,11 +933,14 @@ table.form-table td .updated p {
}
.color-palette {
display: table;
width: 100%;
border-spacing: 0;
border-collapse: collapse;
}
.color-palette .color-palette-shade,
.color-palette td {
display: table-cell;
height: 20px;
padding: 0;
border: none;
@ -1601,12 +1604,15 @@ table.form-table td .updated p {
margin-bottom: 0;
}
.form-table .color-palette .color-palette-shade,
.form-table .color-palette td {
display: table-cell;
width: 15px;
height: 30px;
padding: 0;
}
.form-table table.color-palette {
.form-table .color-palette {
margin-right: 10px;
}

18
src/wp-admin/includes/misc.php
View File

@ -1038,17 +1038,15 @@ function admin_color_scheme_picker( $user_id ) {
<input type="hidden" class="css_url" value="<?php echo esc_url( $color_info->url ); ?>" />
<input type="hidden" class="icon_colors" value="<?php echo esc_attr( wp_json_encode( array( 'icons' => $color_info->icon_colors ) ) ); ?>" />
<label for="admin_color_<?php echo esc_attr( $color ); ?>"><?php echo esc_html( $color_info->name ); ?></label>
<table class="color-palette">
<tr>
<?php
foreach ( $color_info->colors as $html_color ) {
?>
<td style="background-color: <?php echo esc_attr( $html_color ); ?>">&nbsp;</td>
<?php
}
<div class="color-palette">
<?php
foreach ( $color_info->colors as $html_color ) {
?>
</tr>
</table>
<div class="color-palette-shade" style="background-color: <?php echo esc_attr( $html_color ); ?>">&nbsp;</div>
<?php
}
?>
</div>
</div>
<?php