vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-06 10:10:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Themes: Revert appearance tools theme support.

Browse Source 
The appearance tools theme support(merged in [55067]) includes block gap, a feature that was not intended for themes without a theme.json.

Until it has been determined if the feature can and should be enabled in these themes, and has been successfully tested, the appearance tools theme support should be reverted.

Reverts [55067].

Props poena, Mamaduka, audrasjb.
Fixes #57649.

git-svn-id: https://develop.svn.wordpress.org/trunk@55273 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
David Baumwald
2023-02-07 16:42:11 +00:00
parent 67f101e791
commit 5b2a6ae7cc
2 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/wp-includes/class-wp-theme-json-resolver.php
View File

@@ -314,11 +314,6 @@ class WP_Theme_JSON_Resolver {
// Classic themes without a theme.json don't support global duotone.
$theme_support_data['settings']['color']['defaultDuotone'] = false;
// Allow themes to enable appearance tools via theme_support.
if ( current_theme_supports( 'appearance-tools' ) ) {
$theme_support_data['settings']['appearanceTools'] = true;
}
}
$with_theme_supports = new WP_Theme_JSON( $theme_support_data );
$with_theme_supports->merge( static::$theme );

6
tests/phpunit/tests/theme/wpThemeJsonResolver.php
View File

@@ -433,9 +433,6 @@ class Tests_Theme_wpThemeJsonResolver extends WP_UnitTestCase {
/**
* @ticket 54336
* @ticket 56467
*
* @covers ::add_theme_support
*/
public function test_add_theme_supports_are_loaded_for_themes_without_theme_json() {
switch_theme( 'default' );
@@ -458,18 +455,15 @@ class Tests_Theme_wpThemeJsonResolver extends WP_UnitTestCase {
);
add_theme_support( 'editor-color-palette', $color_palette );
add_theme_support( 'custom-line-height' );
add_theme_support( 'appearance-tools' );
$settings = WP_Theme_JSON_Resolver::get_theme_data()->get_settings();
remove_theme_support( 'custom-line-height' );
remove_theme_support( 'editor-color-palette' );
remove_theme_support( 'appearance-tools' );
$this->assertFalse( wp_theme_has_theme_json() );
$this->assertTrue( $settings['typography']['lineHeight'] );
$this->assertSame( $color_palette, $settings['color']['palette']['theme'] );
$this->assertTrue( $settings['border']['color'], 'Support for appearance-tools was not added.' );
}
/**