vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 14:20:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Posts, Post Types: Check if the post type exists in wp_insert_post().

Browse Source 
This avoids an `Attempt to read property "cap" on null` PHP warning when checking an unregistered post type's `publish_posts` capability to disallow contributors setting the post slug for pending posts.

Follow-up to [9055], [42380].

Props Chouby, mukesh27, rafiahmedd, SergeyBiryukov.
Fixes #55877.

git-svn-id: https://develop.svn.wordpress.org/trunk@53771 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2022-07-24 13:24:44 +00:00
parent e2a45c0d8a
commit 6cbed78c94
2 changed files with 24 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/wp-includes/post.php
View File

@@ -4159,12 +4159,14 @@ function wp_insert_post( $postarr, $wp_error = false, $fire_after_hooks = true )
*
* For new posts check the primitive capability, for updates check the meta capability.
*/
$post_type_object = get_post_type_object( $post_type );
if ( 'pending' === $post_status ) {
$post_type_object = get_post_type_object( $post_type );
if ( ! $update && 'pending' === $post_status && ! current_user_can( $post_type_object->cap->publish_posts ) ) {
$post_name = '';
} elseif ( $update && 'pending' === $post_status && ! current_user_can( 'publish_post', $post_ID ) ) {
$post_name = '';
if ( ! $update && $post_type_object && ! current_user_can( $post_type_object->cap->publish_posts ) ) {
$post_name = '';
} elseif ( $update && ! current_user_can( 'publish_post', $post_ID ) ) {
$post_name = '';
}
}
/*

17
tests/phpunit/tests/post.php
View File

@@ -501,6 +501,23 @@ class Tests_Post extends WP_UnitTestCase {
$this->assertStringContainsString( 'wptests_pt=' . $p, $post->guid );
}
/**
* @ticket 55877
* @covers ::wp_insert_post
*/
public function test_wp_insert_post_should_not_trigger_warning_for_pending_posts_with_unknown_cpt() {
$post_id = wp_insert_post(
array(
'post_title' => 'title',
'post_type' => 'unknown',
'post_status' => 'pending',
)
);
$this->assertIsNumeric( $post_id );
$this->assertGreaterThan( 0, $post_id );
}
/**
* @ticket 20451
*/