vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-01 07:40:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Upgrade/Install: Store correct result when bulk updating plugins or themes.

Browse Source 
This ensures that when multiple plugins or themes are updated and one succeeds and another fails, the error is reported accordingly.

Previously, both updates would end up treated as a success, due to `$this->result` containing the result of the previous operation and not the current one.

Follow-up to [12097].

Props pwtyler, afragen.
Fixes #53002.

git-svn-id: https://develop.svn.wordpress.org/trunk@51528 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2021-08-02 20:54:44 +00:00
parent 80ccb3697c
commit 717158ee32
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-admin/includes/class-plugin-upgrader.php
View File

@@ -347,7 +347,7 @@ class Plugin_Upgrader extends WP_Upgrader {
)
);
$results[ $plugin ] = $this->result;
$results[ $plugin ] = $result;
// Prevent credentials auth screen from displaying multiple times.
if ( false === $result ) {

2
src/wp-admin/includes/class-theme-upgrader.php
View File

@@ -448,7 +448,7 @@ class Theme_Upgrader extends WP_Upgrader {
)
);
$results[ $theme ] = $this->result;
$results[ $theme ] = $result;
// Prevent credentials auth screen from displaying multiple times.
if ( false === $result ) {