vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-01 07:40:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Editor: fix post edit navigation link.

Browse Source 
Adds a custom link for navigation post types.

Props get_dave, spacedmonkey, ramonopoly.
Fixes #58589.


git-svn-id: https://develop.svn.wordpress.org/trunk@56053 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Isabel Brison
2023-06-27 06:00:59 +00:00
parent 3d551af3f2
commit 7c4c4a8665
3 changed files with 38 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/wp-includes/link-template.php
View File

@@ -1438,6 +1438,8 @@ function get_preview_post_link( $post = null, $query_args = array(), $preview_li
* pages, posts, attachments, revisions, global styles, templates, and template parts.
*
* @since 2.3.0
* @since 6.3.0 Adds custom link for wp_navigation post types.
* Adds custom links for wp_template_part and wp_template post types.
*
* @param int|WP_Post $post Optional. Post ID or post object. Default is the global `$post`.
* @param string $context Optional. How to output the '&' character. Default '&'.
@@ -1474,6 +1476,8 @@ function get_edit_post_link( $post = 0, $context = 'display' ) {
if ( 'wp_template' === $post->post_type || 'wp_template_part' === $post->post_type ) {
$slug = urlencode( get_stylesheet() . '//' . $post->post_name );
$link = admin_url( sprintf( $post_type_object->_edit_link, $post->post_type, $slug ) );
} elseif ( 'wp_navigation' === $post->post_type ) {
$link = admin_url( sprintf( $post_type_object->_edit_link, (string) $post->ID ) );
} elseif ( $post_type_object->_edit_link ) {
$link = admin_url( sprintf( $post_type_object->_edit_link . $action, $post->ID ) );
}

9
src/wp-includes/post.php
View File

@@ -491,6 +491,14 @@ function create_initial_post_types() {
)
);
$navigation_post_edit_link = 'site-editor.php?' . build_query(
array(
'postId' => '%s',
'postType' => 'wp_navigation',
'canvas' => 'edit',
)
);
register_post_type(
'wp_navigation',
array(
@@ -517,6 +525,7 @@ function create_initial_post_types() {
'description' => __( 'Navigation menus that can be inserted into your site.' ),
'public' => false,
'_builtin' => true, /* internal use only. don't use this when registering your own post type. */
'_edit_link' => $navigation_post_edit_link, /* internal use only. don't use this when registering your own post type. */
'has_archive' => false,
'show_ui' => true,
'show_in_menu' => false,

25
tests/phpunit/tests/link/getEditPostLink.php
View File

@@ -131,4 +131,29 @@ class Tests_Link_GetEditPostLink extends WP_UnitTestCase {
$this->assertSame( $link_default_context, get_edit_post_link( $template_part_post ), 'Second argument `$context` has a default context of `"display"`.' );
$this->assertSame( $link_custom_context, get_edit_post_link( $template_part_post, 'something-else' ), 'Pass non-default value in second argument.' );
}
/**
* Tests getting the edit post link for a wp_navigation post type.
*
* @ticket 58589
* */
public function test_get_edit_post_link_for_wp_navigation_post_type() {
$navigation_post = self::factory()->post->create_and_get(
array(
'post_type' => 'wp_navigation',
'post_name' => 'my_navigation',
'post_title' => 'My Navigation',
'post_content' => '<!-- wp:navigation-link {"label":"WordPress","type":"custom","url":"http://www.wordpress.org/","kind":"custom"} /-->',
'post_excerpt' => 'Description of my Navigation',
)
);
$post_type_object = get_post_type_object( $navigation_post->post_type );
$link_default_context = admin_url( sprintf( $post_type_object->_edit_link, $navigation_post->ID ) );
$link_custom_context = admin_url( sprintf( $post_type_object->_edit_link, $navigation_post->ID ) );
$this->assertSame( $link_default_context, get_edit_post_link( $navigation_post ), 'Second argument `$context` has a default context of `"display"`.' );
$this->assertSame( $link_custom_context, get_edit_post_link( $navigation_post, 'something-else' ), 'Pass non-default value in second argument.' );
}
}