vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-11 16:14:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Coding Standards: Replace PHP alias join() with implode().

Browse Source 
In [52190], some new instances of the `join()` alias were introduced in the test suite.

Using the canonical function name for PHP functions is strongly recommended, as aliases may be deprecated or removed without (much) warning.

This replaces the new `join()` uses with the canonical `implode()` function name.

Follow-up to [46182], [49193], [49805], [52190].

Props david.binda, mukesh27.
Fixes #59389.

git-svn-id: https://develop.svn.wordpress.org/trunk@56616 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Colin Stewart
2023-09-19 12:23:16 +00:00
parent 1cd98779f7
commit 8ce85f99f3
2 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/phpunit/tests/media.php
View File

@@ -552,8 +552,8 @@ https://w.org</a>',
$ids2_srcs[] = 'http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/' . "image$i.jpg";
}
$ids1_joined = join( ',', array_slice( $ids1, 0, 3 ) );
$ids2_joined = join( ',', array_slice( $ids2, 3, 3 ) );
$ids1_joined = implode( ',', array_slice( $ids1, 0, 3 ) );
$ids2_joined = implode( ',', array_slice( $ids2, 3, 3 ) );
$blob = <<<BLOB
[gallery ids="$ids1_joined"]
@@ -638,8 +638,8 @@ BLOB;
$imgs[] = '<figure><img src="' . $url . '" data-id="' . $i . '" /></figure>';
}
$imgs1_joined = join( "\n", array_slice( $imgs, 0, 3 ) );
$imgs2_joined = join( "\n", array_slice( $imgs, 3, 3 ) );
$imgs1_joined = implode( "\n", array_slice( $imgs, 0, 3 ) );
$imgs2_joined = implode( "\n", array_slice( $imgs, 3, 3 ) );
$blob = <<<BLOB
<!-- wp:gallery -->
@@ -677,8 +677,8 @@ BLOB;
}
$ids1_joined = join( ',', array_slice( $ids, 0, 3 ) );
$ids2_joined = join( ',', array_slice( $ids, 3, 3 ) );
$ids1_joined = implode( ',', array_slice( $ids, 0, 3 ) );
$ids2_joined = implode( ',', array_slice( $ids, 3, 3 ) );
$blob = <<<BLOB
<!-- wp:gallery {"ids":[$ids1_joined]} -->
@@ -718,9 +718,9 @@ BLOB;
$imgs[] = '<figure><img src="' . $url . '" data-id="' . $i . '" /></figure>';
}
$ids1_joined = join( "\n", array_slice( $ids, 0, 3 ) );
$ids2_joined = join( "\n", array_slice( $ids, 3, 3 ) );
$imgs2_joined = join( "\n", array_slice( $imgs, 3, 3 ) );
$ids1_joined = implode( "\n", array_slice( $ids, 0, 3 ) );
$ids2_joined = implode( "\n", array_slice( $ids, 3, 3 ) );
$imgs2_joined = implode( "\n", array_slice( $imgs, 3, 3 ) );
$blob = <<<BLOB
[gallery ids="$ids1_joined"]
@@ -762,7 +762,7 @@ BLOB;
}
$imgs_joined = join( "\n", $imgs );
$imgs_joined = implode( "\n", $imgs );
$blob = <<<BLOB
<!-- wp:columns -->
@@ -805,7 +805,7 @@ BLOB;
}
$imgs_joined = join( "\n", $imgs );
$imgs_joined = implode( "\n", $imgs );
$blob = <<<BLOB
<!-- wp:gallery -->

10
tests/phpunit/tests/media/getPostGalleries.php
View File

@@ -575,7 +575,7 @@ BLOB;
}
$ids_joined = join( ',', $ids );
$ids_joined = implode( ',', $ids );
$global_post_id = self::factory()->post->create(
array(
@@ -844,8 +844,8 @@ BLOB;
}
$ids1_joined = join( ',', array_slice( $ids, 0, 3 ) );
$ids2_joined = join( ',', array_slice( $ids, 3, 3 ) );
$ids1_joined = implode( ',', array_slice( $ids, 0, 3 ) );
$ids2_joined = implode( ',', array_slice( $ids, 3, 3 ) );
$blob = <<<BLOB
[gallery ids="$ids1_joined"]
@@ -907,8 +907,8 @@ BLOB;
}
$ids1_joined = join( ',', array_slice( $ids, 0, 3 ) );
$ids2_joined = join( ',', array_slice( $ids, 3, 3 ) );
$ids1_joined = implode( ',', array_slice( $ids, 0, 3 ) );
$ids2_joined = implode( ',', array_slice( $ids, 3, 3 ) );
$blob = <<<BLOB
[gallery ids="$ids1_joined" type="type" foo="bar"]