vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 14:20:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Widgets: Do not use wrapping container in the admin.

Browse Source 
This is due to the new `before|after_sidebar` args, which are empty by default, but can introduce markup that causes admin JS to stop working.

Also adds documentation for the `sprintf()` on `before_sidebar`.

Props audrasjb, lpointet.
See #19709.


git-svn-id: https://develop.svn.wordpress.org/trunk@49560 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Helen Hou-Sandi
2020-11-10 20:38:59 +00:00
parent 2a7d1e2394
commit 9a14f55ace
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/wp-includes/widgets.php
View File

@@ -243,6 +243,7 @@ function register_sidebars( $number = 1, $args = array() ) {
* @type string $after_title HTML content to append to the sidebar title when displayed.
* Default is a closing h2 element.
* @type string $before_sidebar HTML content to prepend to the sidebar when displayed.
* Receives the '$id' argument as %1$s and '$class' as %2$s.
* Outputs after the {@see 'dynamic_sidebar_before'} action.
* Default empty string.
* @type string $after_sidebar HTML content to append to the sidebar when displayed.
@@ -718,7 +719,7 @@ function dynamic_sidebar( $index = 1 ) {
*/
do_action( 'dynamic_sidebar_before', $index, true );
if ( ! empty( $sidebar['before_sidebar'] ) ) {
if ( ! is_admin() && ! empty( $sidebar['before_sidebar'] ) ) {
echo $sidebar['before_sidebar'];
}
@@ -823,7 +824,7 @@ function dynamic_sidebar( $index = 1 ) {
}
}
if ( ! empty( $sidebar['after_sidebar'] ) ) {
if ( ! is_admin() && ! empty( $sidebar['after_sidebar'] ) ) {
echo $sidebar['after_sidebar'];
}