vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 22:30:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Code Modernization: Use wp_trigger_error() in WP_Text_Diff_Renderer_Table magic methods.

Browse Source 
Replaces `trigger_error()` with `wp_trigger_error()` in each of the `WP_Text_Diff_Renderer_Table` magic methods.

[56354] added the dynamic properties deprecation messages to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods. Since that commit, `wp_trigger_error()` was introduced (see [56530]) as a wrapper for `trigger_error()`.

Follow-up to [56354], [56530].

See #58898, #57686.

git-svn-id: https://develop.svn.wordpress.org/trunk@56544 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Tonya Mork
2023-09-07 20:46:53 +00:00
parent a5eddeab2d
commit 9de414277e
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/wp-includes/class-wp-text-diff-renderer-table.php
View File

@@ -521,7 +521,8 @@ class WP_Text_Diff_Renderer_Table extends Text_Diff_Renderer {
return $this->$name;
}
trigger_error(
wp_trigger_error(
__METHOD__,
"The property `{$name}` is not declared. Getting a dynamic property is " .
'deprecated since version 6.4.0! Instead, declare the property on the class.',
E_USER_DEPRECATED
@@ -544,7 +545,8 @@ class WP_Text_Diff_Renderer_Table extends Text_Diff_Renderer {
return;
}
trigger_error(
wp_trigger_error(
__METHOD__,
"The property `{$name}` is not declared. Setting a dynamic property is " .
'deprecated since version 6.4.0! Instead, declare the property on the class.',
E_USER_DEPRECATED
@@ -565,7 +567,8 @@ class WP_Text_Diff_Renderer_Table extends Text_Diff_Renderer {
return isset( $this->$name );
}
trigger_error(
wp_trigger_error(
__METHOD__,
"The property `{$name}` is not declared. Checking `isset()` on a dynamic property " .
'is deprecated since version 6.4.0! Instead, declare the property on the class.',
E_USER_DEPRECATED
@@ -587,7 +590,8 @@ class WP_Text_Diff_Renderer_Table extends Text_Diff_Renderer {
return;
}
trigger_error(
wp_trigger_error(
__METHOD__,
"A property `{$name}` is not declared. Unsetting a dynamic property is " .
'deprecated since version 6.4.0! Instead, declare the property on the class.',
E_USER_DEPRECATED

4
tests/phpunit/tests/diff/wpTextDiffRendererTable.php
View File

@@ -43,6 +43,7 @@ class Tests_Diff_WpTextDiffRendererTable extends WP_UnitTestCase {
public function test_should_throw_deprecation_when_getting_dynamic_property() {
$this->expectDeprecation();
$this->expectDeprecationMessage(
'WP_Text_Diff_Renderer_Table::__get(): ' .
'The property `undeclared_property` is not declared. Getting a dynamic property is ' .
'deprecated since version 6.4.0! Instead, declare the property on the class.'
);
@@ -72,6 +73,7 @@ class Tests_Diff_WpTextDiffRendererTable extends WP_UnitTestCase {
public function test_should_throw_deprecation_when_setting_dynamic_property() {
$this->expectDeprecation();
$this->expectDeprecationMessage(
'WP_Text_Diff_Renderer_Table::__set(): ' .
'The property `undeclared_property` is not declared. Setting a dynamic property is ' .
'deprecated since version 6.4.0! Instead, declare the property on the class.'
);
@@ -104,6 +106,7 @@ class Tests_Diff_WpTextDiffRendererTable extends WP_UnitTestCase {
public function test_should_throw_deprecation_when_isset_of_dynamic_property() {
$this->expectDeprecation();
$this->expectDeprecationMessage(
'WP_Text_Diff_Renderer_Table::__isset(): ' .
'The property `undeclared_property` is not declared. Checking `isset()` on a dynamic property ' .
'is deprecated since version 6.4.0! Instead, declare the property on the class.'
);
@@ -131,6 +134,7 @@ class Tests_Diff_WpTextDiffRendererTable extends WP_UnitTestCase {
public function test_should_throw_deprecation_when_unset_of_dynamic_property() {
$this->expectDeprecation();
$this->expectDeprecationMessage(
'WP_Text_Diff_Renderer_Table::__unset(): ' .
'A property `undeclared_property` is not declared. Unsetting a dynamic property is ' .
'deprecated since version 6.4.0! Instead, declare the property on the class.'
);