vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Media: Remove caching from filter by date in media library.

Browse Source 
Previously, newly uploaded media attachments were missing when filtering media items by date due to lack of cache invalidation.

Props adamsilverstein, teamdnk, afercia, Mista-Flo, joedolson, youknowriad, talldanwp.
Fixes #50025.


git-svn-id: https://develop.svn.wordpress.org/trunk@50067 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Anthony Burchell 2021-01-29 01:34:05 +00:00
parent 044686ac30
commit a8b5b71590
2 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/js/media/models/attachments.js
View File

@ -390,7 +390,6 @@ var Attachments = Backbone.Collection.extend(/** @lends wp.media.model.Attachmen
var props;
if ( this.props.get('query') ) {
props = this.props.toJSON();
props.cache = ( true !== refresh );
this.mirror( wp.media.model.Query.get( props ) );
}
},

14
src/js/media/models/query.js
View File

@ -213,7 +213,6 @@ Query = Attachments.extend(/** @lends wp.media.model.Query.prototype */{
* @method
*
* @param {object} [props]
* @param {Object} [props.cache=true] Whether to use the query cache or not.
* @param {Object} [props.order]
* @param {Object} [props.orderby]
* @param {Object} [props.include]
@ -243,13 +242,11 @@ Query = Attachments.extend(/** @lends wp.media.model.Query.prototype */{
var args = {},
orderby = Query.orderby,
defaults = Query.defaultProps,
query,
cache = !! props.cache || _.isUndefined( props.cache );
query;
// Remove the `query` property. This isn't linked to a query,
// this *is* the query.
delete props.query;
delete props.cache;
// Fill default args.
_.defaults( props, defaults );
@ -288,14 +285,7 @@ Query = Attachments.extend(/** @lends wp.media.model.Query.prototype */{
// Substitute exceptions specified in orderby.keymap.
args.orderby = orderby.valuemap[ props.orderby ] || props.orderby;
// Search the query cache for a matching query.
if ( cache ) {
query = _.find( queries, function( query ) {
return _.isEqual( query.args, args );
});
} else {
queries = [];
}
queries = [];
// Otherwise, create a new query and add it to the cache.
if ( ! query ) {