mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2026-08-11 12:20:22 +00:00
Taxonomy: Optimize wp_delete_term() for large object counts without a default term.
When deleting a term, it has to be removed individually from each object it's connected to, which can take some significant time when there are a lot of objects. By calling `wp_remove_object_terms()` when no default term is required, we can skip the terms fetch/diff step and significantly speed up the deletion process. Props dd32. Fixes #52549. git-svn-id: https://develop.svn.wordpress.org/trunk@50389 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
@@ -1943,6 +1943,11 @@ function wp_delete_term( $term, $taxonomy, $args = array() ) {
|
||||
$object_ids = (array) $wpdb->get_col( $wpdb->prepare( "SELECT object_id FROM $wpdb->term_relationships WHERE term_taxonomy_id = %d", $tt_id ) );
|
||||
|
||||
foreach ( $object_ids as $object_id ) {
|
||||
if ( ! isset( $default ) ) {
|
||||
wp_remove_object_terms( $object_id, $term, $taxonomy );
|
||||
continue;
|
||||
}
|
||||
|
||||
$terms = wp_get_object_terms(
|
||||
$object_id,
|
||||
$taxonomy,
|
||||
@@ -1951,6 +1956,7 @@ function wp_delete_term( $term, $taxonomy, $args = array() ) {
|
||||
'orderby' => 'none',
|
||||
)
|
||||
);
|
||||
|
||||
if ( 1 === count( $terms ) && isset( $default ) ) {
|
||||
$terms = array( $default );
|
||||
} else {
|
||||
@@ -1959,6 +1965,7 @@ function wp_delete_term( $term, $taxonomy, $args = array() ) {
|
||||
$terms = array_merge( $terms, array( $default ) );
|
||||
}
|
||||
}
|
||||
|
||||
$terms = array_map( 'intval', $terms );
|
||||
wp_set_object_terms( $object_id, $terms, $taxonomy );
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user