vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-30 23:30:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Build/Test Tools: Ensure user capability assertions are performed for all default roles.

Browse Source 
The existing assertions were erroneously placed outside the iteration of all users, and therefore were only run against the last user in the list, which is the Subscriber role.

See #51344, #32394


git-svn-id: https://develop.svn.wordpress.org/trunk@49604 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
John Blackbourn
2020-11-15 14:17:31 +00:00
parent e8435082d6
commit ea852af151
1 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tests/phpunit/tests/user/capabilities.php
View File

@@ -8,15 +8,25 @@
*/
class Tests_User_Capabilities extends WP_UnitTestCase {
protected static $users = array(
/**
* @var WP_User[] $users
*/
protected static $users = array(
'administrator' => null,
'editor' => null,
'author' => null,
'contributor' => null,
'subscriber' => null,
);
/**
* @var WP_User $super_admin
*/
protected static $super_admin = null;
/**
* @var int $block_id
*/
protected static $block_id;
public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
@@ -532,16 +542,16 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
$this->assertFalse( user_can( $user, $cap ), "User with the {$role} role should not have the {$cap} capability" );
}
}
$this->assertFalse( $user->has_cap( 'start_a_fire' ), "User with the {$role} role should not have a custom capability" );
$this->assertFalse( user_can( $user, 'start_a_fire' ), "User with the {$role} role should not have a custom capability" );
$this->assertFalse( $user->has_cap( 'do_not_allow' ), "User with the {$role} role should not have the do_not_allow capability" );
$this->assertFalse( user_can( $user, 'do_not_allow' ), "User with the {$role} role should not have the do_not_allow capability" );
$this->assertTrue( $user->has_cap( 'exist' ), "User with the {$role} role should have the exist capability" );
$this->assertTrue( user_can( $user, 'exist' ), "User with the {$role} role should have the exist capability" );
}
$this->assertFalse( $user->has_cap( 'start_a_fire' ), "User with the {$role} role should not have a custom capability" );
$this->assertFalse( user_can( $user, 'start_a_fire' ), "User with the {$role} role should not have a custom capability" );
$this->assertFalse( $user->has_cap( 'do_not_allow' ), "User with the {$role} role should not have the do_not_allow capability" );
$this->assertFalse( user_can( $user, 'do_not_allow' ), "User with the {$role} role should not have the do_not_allow capability" );
$this->assertTrue( $user->has_cap( 'exist' ), "User with the {$role} role should have the exist capability" );
$this->assertTrue( user_can( $user, 'exist' ), "User with the {$role} role should have the exist capability" );
}
/**